zuul
/
nodepool
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+2

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, c96a1b67144225c7a36ec54d85d1c0641f76494d
Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4146\u003e replied on the change"}
This commit is contained in:
Gerrit User 4146 2023-03-10 22:13:17 +00:00 committed by Gerrit Code Review
parent f92ea98f2b
commit 58137fbc14
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
d7b5161ae675ad0e8ec117e5e889213fc257ca90 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "36ffeacd_9a60960c",
"filename": "nodepool/tests/unit/test_webapp.py",
"patchSetId": 1
},
"lineNbr": 156,
"author": {
"id": 4146
},
"writtenOn": "2023-03-10T22:13:17Z",
"side": 1,
"message": "Why is this test, and the ones below here, fine with starting the builder before the webapp? Seems they follow the same basic structure as above which is start the two services then make web requests to inspect image state?",
"revId": "d7b5161ae675ad0e8ec117e5e889213fc257ca90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}