From 85b0954738fd82b4c52acba366f172167f9ce029 Mon Sep 17 00:00:00 2001 From: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 10 Oct 2013 21:47:26 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: I would prefer that you didn't merge this (1 inline comment) One question about simplifying and possibly making parameters more clear. Patch-set: 2 Reviewer: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Workflow=0 --- 5695884bb399672a18626c729f031228c162e844 | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 5695884bb399672a18626c729f031228c162e844 diff --git a/5695884bb399672a18626c729f031228c162e844 b/5695884bb399672a18626c729f031228c162e844 new file mode 100644 index 000000000..b0cd6870e --- /dev/null +++ b/5695884bb399672a18626c729f031228c162e844 @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "key": { + "uuid": "AAAATH//tXk\u003d", + "filename": "nodepool/nodepool.py", + "patchSetId": 2 + }, + "lineNbr": 995, + "author": { + "id": 4146 + }, + "writtenOn": "2013-10-10T21:47:26Z", + "side": 1, + "message": "Do we need reset provider and image here? Looking at the old image update command in nodepoolcmd.py the values passed in as provider and image appear to be identical to those retrieved here.", + "revId": "5695884bb399672a18626c729f031228c162e844", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file