Update patch set 3

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 31083 \u003c31083@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35571\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35571 \u003c35571@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35571\u003e replied on the change"}
This commit is contained in:
Gerrit User 35571 2023-02-14 14:14:51 +00:00 committed by Gerrit Code Review
parent 98e4c18c86
commit 8ad89591c3
1 changed files with 36 additions and 0 deletions

View File

@ -17,6 +17,24 @@
"revId": "0f915f1840e1d40c43d2e80d25489cf43a4563b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ec2e56bf_1c5a6f66",
"filename": "doc/source/aws.rst",
"patchSetId": 1
},
"lineNbr": 726,
"author": {
"id": 35571
},
"writtenOn": "2023-02-14T14:14:51Z",
"side": 1,
"message": "Ack",
"parentUuid": "62401f83_d17ac45d",
"revId": "0f915f1840e1d40c43d2e80d25489cf43a4563b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +51,24 @@
"message": "I think this must be `label.use_spot` instead",
"revId": "0f915f1840e1d40c43d2e80d25489cf43a4563b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cd5d23f3_77e5d98d",
"filename": "nodepool/driver/aws/adapter.py",
"patchSetId": 1
},
"lineNbr": 835,
"author": {
"id": 35571
},
"writtenOn": "2023-02-14T14:14:51Z",
"side": 1,
"message": "I think it makes more sense on the pool level, which would allow you to use Spot and On-Demand instances side-by-side. You could \"encode\" Spot usage into the pool name and let the user decide, whether they want to use Spot or On-Demand. I hope this make sense.",
"parentUuid": "adb511b6_8d9404c8",
"revId": "0f915f1840e1d40c43d2e80d25489cf43a4563b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}