zuul
/
nodepool
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 7118 \u003c7118@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_7118\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_7118\u003e replied on the change"}
This commit is contained in:
Gerrit User 7118 2023-01-20 02:56:08 +00:00 committed by Gerrit Code Review
parent 819be62e84
commit 8eda8252ac
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
34c3dfd6e875917a97349915cadc97d8fba0a214
View File

@ -34,6 +34,24 @@
"parentUuid": "533a92af_62d0fbce",
"revId": "34c3dfd6e875917a97349915cadc97d8fba0a214",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "08ee87f6_6c113cf1",
"filename": "nodepool/driver/openstack/adapter.py",
"patchSetId": 1
},
"lineNbr": 418,
"author": {
"id": 7118
},
"writtenOn": "2023-01-20T02:56:08Z",
"side": 1,
"message": "ahh, yes it won\u0027t be in sequence, more a general idea of the actions\n\n\u003e can the sdk be convinced to log it?\n\nI guess this is done at\n\nhttps://opendev.org/openstack/openstacksdk/src/branch/master/openstack/proxy.py#L307\n\nwhere the proxy chooses between statsd, influxdb and prometheus. It does feel like a \"log\" option there to also output timing data via self.log might be possible, but I can\u0027t see it there...",
"parentUuid": "f4c66915_20a52e5d",
"revId": "34c3dfd6e875917a97349915cadc97d8fba0a214",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}