zuul
/
nodepool
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"removed on reply"}
Attention: {"person_ident":"Gerrit User 4146 \u003c4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Someone else replied on a comment you posted"}
This commit is contained in:
Gerrit User 1 2023-03-10 22:24:20 +00:00 committed by Gerrit Code Review
parent 58137fbc14
commit a07f48a379
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
d7b5161ae675ad0e8ec117e5e889213fc257ca90
View File

@ -16,6 +16,24 @@
"message": "Why is this test, and the ones below here, fine with starting the builder before the webapp? Seems they follow the same basic structure as above which is start the two services then make web requests to inspect image state?",
"revId": "d7b5161ae675ad0e8ec117e5e889213fc257ca90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "217d1d3c_1bc0d997",
"filename": "nodepool/tests/unit/test_webapp.py",
"patchSetId": 1
},
"lineNbr": 156,
"author": {
"id": 1
},
"writtenOn": "2023-03-10T22:24:20Z",
"side": 1,
"message": "I can do this one too. It has a slightly different startup sequence, but it\u0027ll work too.\n\nI don\u0027t think it\u0027s important to update the others -- we technically only need one test to cover this particular startup sequence.",
"parentUuid": "36ffeacd_9a60960c",
"revId": "d7b5161ae675ad0e8ec117e5e889213fc257ca90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}