Update patch set 1
Patch Set 1: (3 comments) Patch-set: 1 CC: Gerrit User 27582 <27582@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_27582\u003e replied on the change"}
This commit is contained in:
parent
49962778f3
commit
acbcbbbbd7
|
@ -0,0 +1,55 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d7561adb_47912962",
|
||||
"filename": "nodepool/driver/static/provider.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 193,
|
||||
"author": {
|
||||
"id": 27582
|
||||
},
|
||||
"writtenOn": "2023-06-02T13:45:02Z",
|
||||
"side": 1,
|
||||
"message": "Should this be enabled by default?",
|
||||
"revId": "ffe05578efbbc70156d7504d86a400bf91d9ac0c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "1a7750c4_92f3d3a5",
|
||||
"filename": "nodepool/driver/static/provider.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 505,
|
||||
"author": {
|
||||
"id": 27582
|
||||
},
|
||||
"writtenOn": "2023-06-02T13:45:02Z",
|
||||
"side": 1,
|
||||
"message": "Should we log some kind of warning here?",
|
||||
"revId": "ffe05578efbbc70156d7504d86a400bf91d9ac0c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d20a33ae_8fc9dffd",
|
||||
"filename": "nodepool/driver/static/provider.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 515,
|
||||
"author": {
|
||||
"id": 27582
|
||||
},
|
||||
"writtenOn": "2023-06-02T13:45:02Z",
|
||||
"side": 1,
|
||||
"message": "Should we also log something here?",
|
||||
"revId": "ffe05578efbbc70156d7504d86a400bf91d9ac0c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue