zuul/nodepool
Code Issues Proposed changes

Fix typo that crashes playback worker when under load

Browse Source 
When reaching the warning level of the playback worker it crashes with
an exception [1]. The reason is a typo in the variable initialization.

[1] Trace
Exception in thread Thread-6 (_playbackWorker):
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.10/threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/nodepool/lib/python3.10/site-packages/nodepool/zk/zookeeper.py", line 926, in _playbackWorker
    if now - self._last_playback_warning > 60:
AttributeError: 'NodeCache' object has no attribute '_last_playback_warning'. Did you mean: '_last_playblack_warning'?

Change-Id: Ib52d475edaebb960f2350cca0f61df779539873f
This commit is contained in:
Tobias Henkel 2023-06-09 11:15:28 +02:00
parent 25af998d64
commit dfb498e797
No known key found for this signature in database
GPG Key ID: 03750DEC158E5FA2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nodepool/zk/zookeeper.py
View File

@ -742,7 +742,7 @@ class NodepoolTreeCache(abc.ABC):
self.zk = zk self.zk = zk
self.root = root self.root = root
self._last_event_warning = time.monotonic() self._last_event_warning = time.monotonic()
self._last_playblack_warning = time.monotonic() self._last_playback_warning = time.monotonic()
self._cached_objects = {} self._cached_objects = {}
self._cached_paths = set() self._cached_paths = set()
self._ready = threading.Event() self._ready = threading.Event()