Update patch set 1

Browse Source

Patch Set 1: I would prefer that you didn't merge this

Since fixed_network is a list, would you mind making the argument name plural (fixed_networks)?  Also, it might be nice to type check it or otherwise handle the case where someone passes in a string (as the current behavior will attempt a network lookup for each character in the stream).

Patch-set: 1
Reviewer: Gerrit User 1 <1@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Label: Workflow=0

...

This commit is contained in:

Gerrit User 1 2013-10-08 16:45:36 +00:00 committed by Gerrit Code Review

parent 6dc9afc12e

commit e749c50724

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available