zuul
/
nodepool
Code Issues Proposed changes

Log decline reason at info 

Admins need to know why requests were declined, and major decisions
should be logged at info level.

Note that the complementary "Accepting node request" may be okay at
debug level as there is a more informative "Assigning node request"
message at info.

Change-Id: I67ac8c75e5581cc4da77cba42a98c5c3785640ff
This commit is contained in:
James E. Blair 2021-04-15 16:22:35 -07:00
parent 9c83e8a95e
commit f0eb830bb7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nodepool/driver/__init__.py
View File

@ -552,8 +552,8 @@ class NodeRequestHandler(NodeRequestHandlerNotifications,
declined_reasons.append('it would exceed quota')
if declined_reasons:
self.log.debug("Declining node request because %s",
', '.join(declined_reasons))
self.log.info("Declining node request because %s",
', '.join(declined_reasons))
self.decline_request()
self._declinedHandlerCleanup()
return