zuul
/
nodepool
Code Issues Proposed changes

Rename get_schema to getSchema 

This corrects an inconsistency with a class method name, where
camel case is the norm.

Change-Id: I0e02f2425c89b46a780ec99d8053fad4b04d3f9a
This commit is contained in:
David Shrewsbury 2018-03-07 21:22:57 -05:00
parent bcd8a2c132
commit f19f89777d
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nodepool/cmd/config_validator.py
View File

@ -78,5 +78,5 @@ class ConfigValidator:
schema = v.Schema(top_level)
schema(config)
for provider_dict in config.get('providers', []):
provider_schema = get_provider_config(provider_dict).get_schema()
provider_schema = get_provider_config(provider_dict).getSchema()
provider_schema.extend(provider)(provider_dict)

2
nodepool/driver/__init__.py
View File

@ -449,5 +449,5 @@ class ProviderConfig(ConfigValue):
pass
@abc.abstractmethod
def get_schema(self):
def getSchema(self):
pass

2
nodepool/driver/openstack/config.py
View File

@ -205,7 +205,7 @@ class OpenStackProviderConfig(ProviderConfig):
top_label = config.labels[pl.name]
top_label.pools.append(pp)
def get_schema(self):
def getSchema(self):
provider_diskimage = {
'name': str,
'pause': bool,

2
nodepool/driver/static/config.py
View File

@ -65,7 +65,7 @@ class StaticProviderConfig(ProviderConfig):
pp.labels.add(label)
config.labels[label].pools.append(pp)
def get_schema(self):
def getSchema(self):
pool_node = {
v.Required('name'): str,
v.Required('labels'): v.Any(str, [str]),

2
nodepool/tests/fixtures/drivers/test/config.py vendored
View File

@ -42,7 +42,7 @@ class TestConfig(ProviderConfig):
newconfig.labels[label].pools.append(testpool)
self.pools[pool['name']] = testpool
def get_schema(self):
def getSchema(self):
pool = {'name': str,
'labels': [str]}
return v.Schema({'pools': [pool]})