This change allows you to specify a dib-cmd parameter for disk images,
which overrides the default call to "disk-image-create". This allows
you to essentially decide the disk-image-create binary to be called
for each disk image configured.
It is inspired by a couple of things:
The "--fake" argument to nodepool-builder has always been a bit of a
wart; a case of testing-only functionality leaking across into the
production code. It would be clearer if the tests used exposed
methods to configure themselves to use the fake builder.
Because disk-image-create is called from the $PATH, it makes it more
difficult to use nodepool from a virtualenv. You can not just run
"nodepool-builder"; you have to ". activate" the virtualenv before
running the daemon so that the path is set to find the virtualenv
disk-image-create.
In addressing activation issues by automatically choosing the
in-virtualenv binary in Ie0e24fa67b948a294aa46f8164b077c8670b4025, it
was pointed out that others are already using wrappers in various ways
where preferring the co-installed virtualenv version would break.
With this, such users can ensure they call the "disk-image-create"
binary they want. We can then make a change to prefer the
co-installed version without fear of breaking.
In theory, there's no reason why a totally separate
"/custom/venv/bin/disk-image-create" would not be valid if you
required a customised dib for some reason for just one image. This is
not currently possible, even modulo PATH hacks, etc., all images will
use the same binary to build. It is for this flexibility I think this
is best at the diskimage level, rather than as, say a global setting
for the whole builder instance.
Thus add a dib-cmd option for diskimages. In the testing case, this
points to the fake-image-create script, and the --fake command-line
option and related bits are removed.
It should have no backwards compatibility effects; documentation and a
release note is added.
Change-Id: I6677e11823df72f8c69973c83039a987b67eb2af
Nodepool container fails with error message:
whoami: extra operand ‘/dev/null’
Try 'whoami --help' for more information.
Change-Id: I7ef5b6527eb08d00b9b27e37b5d5b5dce69bb4ef
Infra has a mirror for Debian Buster now, add boot tests
Depends-On: https://review.openstack.org/649496
Change-Id: Ib1567b2576631c078fe11d0f250aeb4e6f9fa0b3
We currently only need to setup the zNode caches in the
launcher. Within the commandline client and the builders this is just
unneccessary work.
Change-Id: I03aa2a11b75cab3932e4b45c5e964811a7e0b3d4
Replace Fedora 28 with Fedora 29 functional testing.
Note this changes our Red Hat platforms to use NetworkManager for
interface configuration, rather than legacy scripts. Fedora 29 has
split the legacy scripts into a new package and it marked for future
removal. NetworkManager is the default on Centos 7 and will also be
on Centos 8, so it makes sense to use it there too.
Depends-On: https://review.openstack.org/619120
Change-Id: I640838c68a05f3b22683c1e90279725a77678526
Running a bit behind on this transition ... s/27/28/ to update to
Fedora 28. This is the default in dib now.
Change-Id: I648ab9d9ba4bba7323c432c65f3ef056703f4303
We have been running into what appear to be zookeeper performance issues
causing tests to fail. Run the zookeeper on a tmpfs to reduce the impact
of iops to disk.
Other alternatives include using something like eatmydata to make writes
and syncs fast but unsafe.
Change-Id: Iea5e44af6844281c7f2078da57da9f13691e2642
This allows us to set parameters for server boot on various images.
This is the equivalent of the "--property" flag when using "openstack
server create". Various tools on the booted servers can then query
the config-drive metadata to get this value.
Needed-By: https://review.openstack.org/604193/
Change-Id: I99c1980f089aa2971ba728b77adfc6f4200e0b77
openSUSE Leap 15 is the latest version of openSUSE, bring an image
online to validate we can properly build it.
Depends-On: https://review.openstack.org/#/c/572424/
Change-Id: Ib0f48d9788aafd763e857c2d33784c4f75af4c17
Now that debian-stretch is working as expected, we can remove
debian-jessie.
Change-Id: If897757023772bb4549e40e7fcd048998175fb5b
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
We are seeing consistent failures where the Trusty root partition is
64MiB shorter than we expect. Unfortunately we don't currently have a
concrete explanation for this but rounding due to alignment is
suspected.
Reduce the expected size to something bigger than the images, but not
so close to 5GiB. Also add a more useful failure message; currently
you have to dig back through the logs to see where it went wrong.
Change-Id: Iba1fafdb1fe0f3c1b751772af939f079c429fcf3
If a build has a systematic failure, we currently just let nodepool
run, looping builds until we hit the overall job timeout (1.5 hours).
This adds a count of output log files; if we see three failed builds,
then assume the problem won't get better and fail early.
Change-Id: Id7e163b4937dd57cc8afbf72ed795f73b46a05b1
It seems that 2MiB of fudge isn't quite enough; Trusty has been seen
to round it's root partition size down and we miss it. Increase the
fudge factor.
Change-Id: I26e3bc7b5f68ea6642b8b57119fbd286688d593e
Test that we see the root partition grow.
Increase the root disk size to 5gb, and check that the booted vm has
grown the disk to at least that. Add disk size tracking so we can
more clearly see what's being built into the images.
Change-Id: I377beffc4896e03f0c2d01c0061c5f8652e8b1d1
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Increase our test coverage for debian-stretch, as this is the latesst
stable version of debian.
Change-Id: I05cbfe9735eb0b3900203fbd423f68483b1cbf5d
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Since ubuntu-bionic is the next LTS version of Ubuntu, start work to
ensure we can build DIBs for it.
We'll also need to bring online AFS mirrors.
Change-Id: I2e523eee4e99e5aea3d57d7ad224dbec39e2e4a5
Depends-On: https://review.openstack.org/485748
Depends-On: https://review.openstack.org/545611
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Several fixes to this job:
We need to run bindep twice - once for nodepool, once for zuul. Add
invocation of bindep role and also copy install-distro-packages so that
the job works, next step is remove the install-distro-packages from
zuul.
Add a post-run to copy the nodepool logs, so you can diagnose what's
going wrong if the jobs fails
Fix up a configuration issue, it tries to write build-logs to
/var/log/nodepool which it doesn't own, redirect to the temp area.
Add it as a non-voting check job
Depends-On: https://review.openstack.org/545163
Change-Id: I12db55d3e4c7a71b9af56567858df0a620ee3b73
We'd like to bring opensuse-tumbleweed online for openstack-infra, so
enable testing of tumbleweed to help catch things.
Change-Id: Id0a1fbf6f3c7df63402670f8c54f7fb3af652ae5
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Validate that glean will properly use the key-name from nodepool, and
allow a root user to ssh into the node.
It seems when we merge feature/zuulv3 back into master, we lost this
logic. It is still helpful to actually SSH into a node to validate
glean and diskimage-builder worked as expected.
See: https://review.openstack.org/455770/
Change-Id: I03f7f04be6c7889f94abed2d9e0a56d7e05ad90f
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Fedora-27 is the latest supported version, switch to it. We also have
fedora-27 DIBs live in openstack-infra.
Change-Id: Iff9e01a8aab4ba50c42e5e72fabbe8cb20bc821c
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Both fedora-25 and ubuntu-precise are nolonger tested. Remove dead
logic.
Change-Id: Ib54827bfea01cec39bd161a5a94fee350556102f
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
These matches were only required for the legacy boot jobs, which are
now removed.
Change-Id: I2ab0d1172fb596d4f85481175cf754c17d406d12
Depends-On: https://review.openstack.org/543329
This implements legacy-dsvm-nodepool-[distro]-src jobs as native jobs.
This seems like the best home for them, as they are run by multiple
externals such as glean and diskimage-builder.
Previously the defaults were set such that with no arguments, the
trusty test ran for nodepool-functional-py35.
To facilitate better templating, this turns all builds off by default.
The nodepool functional test is moved to a base template, and then
nodepool-functional-py35 explicitly builds and boots Xenial now
(trusty doesn't seem very useful).
The check_devstack_plugin.sh script runs after devstack, so needs to
source the stackrc file to pull in the variables about what images are
paused or not.
Additionally, the path for the script is fixed to nodepool so we can
run the job from other projects.
The redhat, ubuntu and suse legacy tests are re-implemented for their
respective builds.
This also highlighted that the opensuse test wasn't actually doing
anything. This actually adds the configuration to build opensuse-423.
Needed-By: https://review.openstack.org/543270
Needed-By: https://review.openstack.org/543328
Needed-By: https://review.openstack.org/543329
Needed-By: https://review.openstack.org/543330
Change-Id: I203d149a1d63ac8358e1c8b878d9c2bc0ba67c02
The legacy-dsvm-nodepool-*-src jobs use this script, but don't pass
the argument added by I203d149a1d63ac8358e1c8b878d9c2bc0ba67c02.
Default it while we migrate everything.
Change-Id: I30943a3242d80ab87f6a89ec7f2bcfd3d62ad64b
Changes nodepool-functional-py35 and nodepool-functional-py35-src
to use the native devstack job and not the legacy job.
Change-Id: I3d97d83360816001da0f599d95b13eae3abb6c96
This change is a follow-up to the drivers spec and it makes the fake provider
a real driver. The fakeprovider module is merged into the fake provider and
the get_one_cloud config loader is simplified.
Change-Id: I3f8ae12ea888e7c2a13f246ea5f85d4a809e8c8d
Fedora 26 is now the latest version, so lets start supporting it for
nodepool devstack testing.
https://fedoraproject.org/wiki/Releases/26/Schedule
Change-Id: I9cde430a8cda53357851ab527446f6b32919907e
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
No need to build ubuntu-precise any more, it is EOL.
Change-Id: I16ef944d01c699971a136600da8e7e3c710919a3
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
It's possible that it's easier for a nodepool user to just specify a
name or id of a flavor in their config instead of the combo of min-ram
and name-filter.
In order to not have two name related items, and also to not have the
pure flavor-name case use a term called "name-filter" - change
name-filter to flavor-name, and introduce the semantics that if
flavor-name is given by itself, it will look for an exact match on
flavor name or id, and if it's given with min-ram it will behave as
name-filter did already.
Change-Id: I8b98314958d03818ceca5abf4e3b537c8998f248
The nodepool_id feature may need to be removed. I've kept it to simplify
merging both now and if we do it again later.
A couple of the tests are disabled and need reworking in a subsquent
commit.
Change-Id: I948f9f69ad911778fabb1c498aebd23acce8c89c
The day has come to rename nodepoold to nodepool-launcher.
Change-Id: Ic04e3cf2dbdaf914bf8f92d073acb972380708f1
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Ian Wienand