Require TLS Zookeeper connections before making the 4.0 release.
Change-Id: I69acdcec0deddfdd191f094f13627ec1618142af
Depends-On: https://review.opendev.org/776696
We've had it in here as a way to pin pycodestyle. But that's not
worth the energy to deal with things like hacking now spewing
incorrect messages about our apache license headers not being
right even though they are. (it's because sdague dedcided that
nobody has more than 11 lines of header)
zuul just uses a bare flake8. Match that choice.
Change-Id: I5bc847d151801fd31281389ee65184e964ddd2a5
Depends-On: https://review.opendev.org/712778
Replace our tox-py36 job with tox-py38, extend the list of trove
classifiers for Python versions in package metadata, and replace the
"py35" in the tox.ini envlist with just "py3" so that folks running
`tox` unqualified on their systems will use whatever python3
interpreter they have on hand (odds are it's in our supported range
these days). Also uncap python-daemon so we use a version compatible
with Python >=3.8.
Change-Id: Ic464eefbd90ffaa2ef9079a23e7b15c167de3103
New ignored errors/warning:
- W504: line break after binary operator
- E741: do not use variables named ‘l’, ‘O’, or ‘I’
Fixed issues:
- E117: over-indented
This was tested locally with flake8==3.7.9 with Python 3.8.
The currently used version of flake8 (2.6.2) is not compatible with
Python 3.8. Unfortunately the dependency is coming in via
diskimage-builder>=2.0 -> hacking<1.2.0,>=1.1.0 -> flake8<2.7.0,>=2.6.0
Change-Id: Idf8b6033232fdce91cb37c8396dab6cc27c75968
The most important thing is that the URL for glean is actually
wrong, which causes jobs to fail.
Also, change documentation while we're changing things.
Depends-On: https://review.opendev.org/655133
Change-Id: I127a33bfc4a3e33249120dcc7ef6142ce4e52a97
This change implements an OpenShift resource provider. The driver currently
supports project request and pod request to enable both containers as machine
and native containers workflow.
Depends-On: https://review.openstack.org/608610
Change-Id: Id3770f2b22b80c2e3666b9ae5e1b2fc8092ed67c
Rather than setting it in all of the envs, set it in the main env. Then
add ignore_basepython_conflict option to tox.ini so that doing so
doesn't mess with py35, py36 and py37's python setting.
Change-Id: I72fa337b2b7be1823beeb3f3bfc4bd23589c007d
Reorganizes the unit tests into a new subdirectory, and
adds a new functional test subdirectory (that will be further
divided into subdirs for drivers).
Change-Id: I027bba619deef9379d293fdd0457df6a1377aea8
Use tox -e docs for building with the new build-tox-docs template.
Update tox.ini to enable warnings as errors to follow previous
behaviour.
Change-Id: I8c4547c3e835515744b9a94ccfeb258989169051
Move all doc related requirements to a separate requirements.txt so
that the tests do not install unneccessary dependencies.
Change-Id: I276775ee2d038209f82bfb42dca386a2f5bf02f0
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I397efa210d0489fcea1240a305b65f06511081f1
stestr is maintained, while testrepository is not. OpenStack is
migrating to stestr, go ahead and follow suit.
The --no-subunit-trace flag is added to keep the quiet test run
behavior. If we remove it, stestr will by default print the name of each
test as it starts it.
This uses environment inclusions which need tox 2.8.1 due to a bug fix.
So increase the tox minversion.
Change-Id: I08cd4bee86b56d9a68644b049497c34e34e5f226
docs is a recommended developer convenience environment for doing the
sphinx build locally. The zuul job runs the sphinx-build command. Update
the docs env to do the same thing.
Move the job definitions in-tree - and also remove tox-docs.
Change-Id: Id810b8de1794b11b236eaa04940acbb754dd4b52
Currently the flake8 config seems to be broken as only H231, H233 and
F are selected but nothing from the formatting checks (E). I think we
should use the same set as in zuul.
Change-Id: Ifd48129386d42e87be8326358d43fc1c0d8b0eac
'tox -edocs' will annoyingly use py2 if it's available. Since
everything else is py3, do that for docs, too.
Change-Id: Ia8bbde27ad4d97fd6b0859536580a2268bda0933
Start working on low hanging fruit for python3 support.
Change-Id: I6d52c3a4ad4d383437925ecae6002de7528c9be0
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This gives us to ability to start manging OS dependencies for zuul.
Change-Id: Ic3c3848258354c3c6ecc866c48ac4a77bb3d187f
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
It can be handy to test against an already running zookeeper, rather
than requiring one be installed in your test environment. Allow for
that by using the NODEPOOL_ZK_HOST environment variable.
This also gives each ZKTestCase based test a pre-existing client
connection that can be used for testing. To avoid znode path conflicts,
each connection is chroot'ed under /nodepool_test/{uniqueInt}. We
attempt to remove the {uniqueInt} znode and children as part of the
test cleanup (also removed at setUp time if cleanup fails). This will
leave a single znode for /nodepool_test, but if many tests fail for
some reason, it is easier to remove a single root node rather than
potentially many of them if we do not chroot.
Change-Id: I4fd61b16353c16bed2744e0d863ce188019430cd
This will catch unused vars and unused imports and similar code hygeine
items. Note this doesn't enable the other rules because we are trying to
ignore some and enable others and that doesn't seem doable with the
select/ignore lists.
Change-Id: If88de411bb18b395c3be492c0a6dccec50fe98f2
As per the governance resolution https://review.openstack.org/119875
projects should have a docs environment in their tox.ini testing
interface.
Change-Id: I5908033d835d35a0650b77b01ff727d81eb79eb0
According to https://docs.python.org/3/howto/pyporting.html the
syntax changed in Python 3.x. The new syntax is usable with
Python >= 2.6 and should be preferred to be compatible with Python3.
Enabled hacking check H231.
Change-Id: Ide60f971493440311f1dcc594e33d536beb925e5
Override tox's pip install command so that prereleases (alphas, betas,
broken things) aren't installed by default. Instead only install release
versions unless a prerelease version is specifically provided. Do this
by overriding the tox install command value.
This fixes doc builds that use `tox -evenv python setup.py
build_sphinx`.
Also, remove the gearman servers from the test configuration (since there
is not yet any support for it).
Change-Id: I31913420adcb48866d3996f2dd3b605c55acce2e
Finish the initial sections defined in the documentation index.
Add sphinxcontrib-programoutput to document command line utils.
Add py27 to the list of default tox targets.
Change-Id: I254534032e0706e410647b023249fe3af4f3a35f
Some of us have hacking installed global, which means nodepool flake8
produces a lot of spurious warnings. Suppress them.
Change-Id: Ie869a92fa423dc022c5c37c102f5a9071ccaf1b0
James E. Blair