Update patch set 28
Patch Set 28: Code-Review-1 (1 comment) Looks like we're also still waiting on the test update I mentioned in PS27. Patch-set: 28 Reviewer: Gerrit User 1 <1@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 513bf57849d57d43803a2454c32380ada585a409
This commit is contained in:
parent
e56d4b4f69
commit
0a2dcf3e23
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "1ddd5cd9_ceeb6438",
|
||||
"filename": "roles/prepare-workspace-git/README.rst",
|
||||
"patchSetId": 28
|
||||
},
|
||||
"lineNbr": 19,
|
||||
"author": {
|
||||
"id": 1
|
||||
},
|
||||
"writtenOn": "2024-02-16T17:57:53Z",
|
||||
"side": 1,
|
||||
"message": "The old variable name wasn\u0027t great since you decided to sync required projects and also the project under test, but I think it was better than this. This makes me think that normally we don\u0027t sync required projects and you need to set this to true in order to do that. I think the old name was better (especially since we document the edge case below), but I\u0027m open to other ideas if you have them. I don\u0027t have a better suggestion.",
|
||||
"revId": "3b3bd4d5943c44bd8c75f2003f13de81e6ebbbff",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue