From 0f662a23d06ae12736e73fd29ac39eae19e878b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rados=C5=82aw=20Piliszek?= Date: Tue, 20 Jun 2023 17:06:36 +0200 Subject: [PATCH] Drop Helm v2 support to fix v3 issue Helm v2 is long gone and there seems to be no interest in supporting it any longer. [1] Dropping support for v2 allows for an easy fix to the command used so that it names the release properly as it was supposed to instead of trying to set the namespace name (the -n switch changed purpose [1]). [1] https://lists.zuul-ci.org/archives/list/zuul-discuss@lists.zuul-ci.org/thread/WUWBM5F3PXXDLKK6JNSP4UR4VTWDNPZ4/ Story: 2010783 Task: 48201 Change-Id: I00676bcc7e8b4f3ec014f2292c6c0ee4c17acd96 --- roles/helm-template/tasks/main.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/helm-template/tasks/main.yaml b/roles/helm-template/tasks/main.yaml index 78c4873f6..63920a81a 100644 --- a/roles/helm-template/tasks/main.yaml +++ b/roles/helm-template/tasks/main.yaml @@ -4,14 +4,14 @@ chdir: "{{ zuul_work_dir }}" - name: Print templated charts - command: "helm template -n zuul {{ helm_chart }}" + command: "helm template zuul {{ helm_chart }}" args: chdir: "{{ zuul_work_dir }}" - name: Deploy templated charts shell: | set -o pipefail - helm template {% if helm_values_file is defined %}--values {{ helm_values_file }} {% endif %}-n {{ helm_release_name }} {{ helm_chart }} | kubectl apply -f- + helm template {% if helm_values_file is defined %}--values {{ helm_values_file }} {% endif %}{{ helm_release_name }} {{ helm_chart }} | kubectl apply -f- args: executable: /bin/bash chdir: "{{ zuul_work_dir }}"