zuul
/
zuul-jobs
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(1 comment)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 27582 \u003c27582@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Someone else replied on a comment you posted"}
Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"removed on reply"}
This commit is contained in:
Gerrit User 1 2022-09-23 14:54:23 +00:00 committed by Gerrit Code Review
parent e3e6dcfd99
commit 10b45420e5
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
3e7f0f5beabfc27010d7f0fb2f58bd2e2ff915e1
View File

@ -34,6 +34,24 @@
"parentUuid": "3c9f8b42_1c7427e1",
"revId": "3e7f0f5beabfc27010d7f0fb2f58bd2e2ff915e1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3c67203f_33cc23bd",
"filename": "roles/upload-logs-base/library/zuul_s3_upload.py",
"patchSetId": 7
},
"lineNbr": 101,
"author": {
"id": 1
},
"writtenOn": "2022-09-23T14:54:23Z",
"side": 1,
"message": "Our log roles are expected to handle the case where the container is already created and correct settings where necessary, so we should not perform this only on container creation. It is unfortunate that AWS can\u0027t handle collisions like that. Other log upload roles do this on every upload without incident (it should be a no-op).\n\nIt seems like the best solution would be to perform a GET of the CORS rules and then update them if they are not correct. Maybe that\u0027s a solution for the lifecycle change too?",
"parentUuid": "3c9f8b42_1c7427e1",
"revId": "3e7f0f5beabfc27010d7f0fb2f58bd2e2ff915e1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}