zuul
/
zuul-jobs
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(1 comment)

Patch-set: 7
Reviewer: Gerrit User 27582 <27582@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 27582 2022-09-23 07:07:45 +00:00 committed by Gerrit Code Review
parent 4eb51bf567
commit 11494ca0f6
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
3e7f0f5beabfc27010d7f0fb2f58bd2e2ff915e1 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "3c9f8b42_1c7427e1",
"filename": "roles/upload-logs-base/library/zuul_s3_upload.py",
"patchSetId": 7
},
"lineNbr": 101,
"author": {
"id": 27582
},
"writtenOn": "2022-09-23T07:07:45Z",
"side": 1,
"message": "It doesn\u0027t seem to be necessary to update the CORS rules on every log upload. Once set, the rules will be valid for the future and apply to the whole bucket.\n\nFor context: https://review.opendev.org/c/zuul/zuul-jobs/+/790050 adds support for configuring log retention on upload and we are using this already in our deployment.\n\nHowever, in our Zuul configuration of the S3 upload role we had to set `zuul_log_delete_after_days` to 0 as log uploads will sometimes fail if there are too many requests that try to update the lifecycle policy. I think the same will be true for the CORS rules. (we configure the bucket lifecycle policy when we initially created the bucket).\n\nI\u0027d propose to rebase this change on 790050 and only configure the CORS rules when `create_bucket` is set to True.",
"revId": "3e7f0f5beabfc27010d7f0fb2f58bd2e2ff915e1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}