Merge "Don't compare to literal True/False"

This commit is contained in:
Zuul 2019-08-02 15:22:42 +00:00 committed by Gerrit Code Review
commit 2ceabc5cc8
4 changed files with 5 additions and 7 deletions

View File

@ -8,5 +8,4 @@
- name: Create a new key in workspace based on build UUID
include: create-key-and-replace.yaml
when:
- zuul_temp_ssh_key_stat.stat.exists != True
when: not zuul_temp_ssh_key_stat.stat.exists

View File

@ -117,7 +117,7 @@
# Remove newly created pot files
rm -f ${DIRECTORY}/source/locale/*.pot
when: translations.stat.exists == True
when: translations.stat.exists
- name: Run releasenotes sphinx build
shell:

View File

@ -8,7 +8,7 @@
url: https://storage.googleapis.com/minikube/releases/{{ minikube_version }}/minikube-linux-amd64
dest: /tmp/minikube
mode: 0755
when: stat_result.stat.exists == False
when: not stat_result.stat.exists
- name: Run install-docker role
include_role:

View File

@ -44,11 +44,10 @@ commands =
# [ANSIBLE0012] Commands should not change things if nothing needs doing
# [204] Lines should be no longer than 160 chars
# [206] Variables should have spaces before and after: {{ var_name }}
# [601] Don't compare to literal True/False
bash -c "find playbooks -type f -regex '.*.ya?ml' -print0 | \
xargs -t -n1 -0 ansible-lint -xANSIBLE0012,204,206,601"
xargs -t -n1 -0 ansible-lint -xANSIBLE0012,204,206"
bash -c 'find roles -maxdepth 1 -mindepth 1 -type d -printf "%p/\n" | \
xargs -t -n1 ansible-lint -xANSIBLE0012,204,206,601'
xargs -t -n1 ansible-lint -xANSIBLE0012,204,206'
# Ansible Syntax Check
bash -c "find playbooks -type f -regex '.*.ya?ml' -exec \
ansible-playbook --syntax-check -i {toxinidir}/tests/inventory \{\} + > /dev/null"