Merge "Fix linting issues found via project-config"

roles/configure-mirrors/handlers/main.yaml

@@ -3,6 +3,9 @@
 - name: Update apt cache
   become: yes
   command: apt-get update
+  # skip linting for above comment
+  tags:
+    - skip_ansible_lint
 
 - name: Update dnf cache
   become: yes

roles/emit-job-header/tasks/main.yaml

@@ -1,4 +1,5 @@
-- include_role:
+- name: include the log path role
+  include_role:
     name: set-zuul-log-path-fact
 
 - debug:

roles/mirror-workspace-git-repos/tasks/main.yaml

@@ -1,9 +1,17 @@
 - name: Allow pushing to non-bare repo
-  command: "git config --local receive.denyCurrentBranch ignore"
+  git_config:
-  args:
+    scope: local
-    chdir: "{{ ansible_user_dir }}/{{ item.src_dir}}"
+    name: receive.denyCurrentBranch
+    value: ignore
+    repo: "{{ ansible_user_dir }}/{{ item.src_dir}}"
   with_items: "{{ zuul.projects }}"
 
+- block:
+  # Do not lint these tasks, gets confused by git actions that cannot be done
+  # by git modules
+  tags:
+    - skip_ansible_lint
+
   - name: Synchronize src repos to workspace directory
     command: "git push --mirror git+ssh://{{ ansible_user }}@{{ ansible_host }}/{{ ansible_user_dir }}/{{ item.src_dir}}"
     args:

roles/upload-logs/tasks/main.yaml

@@ -1,4 +1,5 @@
-- include_role:
+- name: include the log path role
+  include_role:
     name: set-zuul-log-path-fact
 
 - name: Create log directories