zuul
/
zuul-jobs
Code Issues Proposed changes

Update patch set 8 

Patch Set 8: Code-Review+2

(1 comment)

Patch-set: 8
Reviewer: Gerrit User 27582 <27582@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
Attention: {"person_ident":"Gerrit User 27582 \u003c27582@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_27582\u003e replied on the change"}
This commit is contained in:
Gerrit User 27582 2022-09-26 05:23:37 +00:00 committed by Gerrit Code Review
parent 9d4a40bf80
commit 462eebb2f0
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
3e7f0f5beabfc27010d7f0fb2f58bd2e2ff915e1
View File

@ -52,6 +52,24 @@
"parentUuid": "3c9f8b42_1c7427e1",
"revId": "3e7f0f5beabfc27010d7f0fb2f58bd2e2ff915e1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "708d4405_430b5d44",
"filename": "roles/upload-logs-base/library/zuul_s3_upload.py",
"patchSetId": 7
},
"lineNbr": 101,
"author": {
"id": 27582
},
"writtenOn": "2022-09-26T05:23:37Z",
"side": 1,
"message": "wfm. I\u0027m not too keen on the extra API requests on every upload for something that\u0027s probably not changing very often, but I think it\u0027s better to be consistent here.\n\nI\u0027ll add a comment to 790050",
"parentUuid": "3c67203f_33cc23bd",
"revId": "3e7f0f5beabfc27010d7f0fb2f58bd2e2ff915e1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}