From 495c5ed62e5c415083bbfb1fd8d5b163dc343b2f Mon Sep 17 00:00:00 2001 From: Andreas Jaeger Date: Fri, 14 Aug 2020 09:49:47 +0200 Subject: [PATCH] Disable E208 for now ansible-lint throws an undocumented error "E208 File permissions not mentioned" that looks too aggressive, for example it complains IMHO wrongly about: roles/add-build-sshkey/tasks/remote-linux.yaml:1: [E208] File permissions not mentioned roles/add-build-sshkey/tasks/remote-linux.yaml:14: [E208] File permissions not mentioned roles/add-build-sshkey/tasks/remote-linux.yaml:20: [E208] File permissions not mentioned roles/add-build-sshkey/tasks/remote-linux.yaml:27: [E208] File permissions not mentioned Disable it for now until ansible-lint is fixed - and the real problems in zuul-jobs are fixed. https://github.com/ansible/ansible-lint/pull/949 fixes the false positives. Once that is merged and a new release is out, we should revert and fix the real problems. Change-Id: I3e3978bbc9458ad79623d22969344fb46f5fee43 --- .ansible-lint | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.ansible-lint b/.ansible-lint index b8309e061..515cb0eb0 100644 --- a/.ansible-lint +++ b/.ansible-lint @@ -5,6 +5,10 @@ quiet: false skip_list: - '106' # Role name does not match ``^[a-z][a-z0-9_]+$`` pattern - '204' # Lines should be no longer than 160 chars + # TODO(AJaeger): E208 gives false positives currently, we + # should enable it once all issues in zuul-jobs and + # ansible-lint are fixed. + - '208' # File permissions not mentioned - '301' # Commands should not change things if nothing needs doing rulesdir: - ./.rules/