Update ANSIBLE_LIBRARY to use envsitepackagesdir

We install zuul via test-requirements, so the zuul files should be in a
directory under the site-packges of the virtualenv that tox installed it
in to. Update the path to point correctly to that location.

Remove the ansible-lint skip tags which should now work because the
library path should be pointing to a location that actually holds the
content.

Change-Id: If2d4b39267c4b9a3102a951143b568f8447af8d9

roles/prepare-workspace/tasks/main.yaml

@@ -1,9 +1,6 @@
 # TODO(pabelanger): Handle cleanup on static nodes
 - name: Start zuul_console daemon.
   zuul_console:
-  tags:
-    # Avoid "no action detected in task" linter error
-    - skip_ansible_lint
 
 - name: Synchronize src repos to workspace directory.
   synchronize:

roles/start-zuul-console/tasks/main.yaml

@@ -1,6 +1,3 @@
 # TODO(pabelanger): Handle cleanup on static nodes
 - name: Start zuul_console daemon.
   zuul_console:
-  tags:
-    # Avoid "no action detected in task" linter error
-    - skip_ansible_lint

roles/upload-logs-swift/tasks/main.yaml

@@ -36,6 +36,3 @@
       zuul:
         log_url: "{{ upload_results.url }}/"
   when: upload_results is defined
-  tags:
-    # Avoid "no action detected in task" linter error
-    - skip_ansible_lint

roles/upload-logs/tasks/main.yaml

@@ -57,6 +57,3 @@
       zuul:
         log_url: "{{ zuul_log_url }}/{{ zuul_log_path }}/"
   when: zuul_log_url is defined
-  tags:
-    # Avoid "no action detected in task" linter error
-    - skip_ansible_lint

tox.ini

@@ -32,7 +32,7 @@ passenv =
   # see openstack-zuul-jobs-linters job for more information.
   ANSIBLE_ROLES_PATH
 setenv =
-  ANSIBLE_LIBRARY= {envdir}/src/zuul/zuul/ansible/library
+  ANSIBLE_LIBRARY= {envsitepackagesdir}/zuul/ansible/library
 whitelist_externals = bash
 commands =
   flake8 {posargs}