zuul/zuul-jobs
Code Issues Proposed changes

Only do the bindep_command if bindep_file is defined

Browse Source 
If there is no bindep file at all in the repository (which is likely
because tox depends on bindep and won't always be useful) then
bindep_file is never set. Then when the set_face bindep_command comes
around it tries to reference the unset bindep_file and fails.

Change-Id: I7be6be88209810eed715daaa4bb41315e838272d
Signed-off-by: Jamie Lennox <jamielennox@gmail.com>
This commit is contained in:
Jamie Lennox 2017-09-05 16:21:14 +10:00
parent 4fdad7a741
commit 60328fef8c
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
roles/bindep/tasks/main.yaml
View File

@ -27,6 +27,7 @@
- name: Define bindep_command fact - name: Define bindep_command fact
set_fact: set_fact:
bindep_run: "{{ bindep_command }} -b -f {{ bindep_file }} {{ bindep_profile }}" bindep_run: "{{ bindep_command }} -b -f {{ bindep_file }} {{ bindep_profile }}"
when: bindep_file is defined
- include: packages.yaml - include: packages.yaml
when: bindep_file is defined when: bindep_file is defined