zuul/zuul-jobs
Code Issues Proposed changes

Add no_log to all log upload tasks

Browse Source 
Some log upload tasks were missing no_log instructions and might
write out credentials to the job-output.json file.  Update these
tasks to include no_log.

Change-Id: I1f18cec117d9205945644ce19d5584f5d676e8d8
This commit is contained in:
James E. Blair 2022-11-16 09:11:12 -08:00
parent b80a0ff3e2
commit 622baa65bf
3 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
roles/upload-logs-gcs/tasks/main.yaml
View File

@ -19,6 +19,7 @@
- name: Upload logs to Google Cloud Storage - name: Upload logs to Google Cloud Storage
delegate_to: localhost delegate_to: localhost
no_log: true
zuul_google_storage_upload: zuul_google_storage_upload:
partition: "{{ zuul_log_partition }}" partition: "{{ zuul_log_partition }}"
container: "{{ zuul_log_container }}" container: "{{ zuul_log_container }}"

1
roles/upload-logs-s3/tasks/main.yaml
View File

@ -23,6 +23,7 @@
- name: Upload logs to S3 - name: Upload logs to S3
delegate_to: "{{ _undocumented_test_worker_node_ | default('localhost') }}" delegate_to: "{{ _undocumented_test_worker_node_ | default('localhost') }}"
no_log: true
zuul_s3_upload: zuul_s3_upload:
endpoint: "{{ upload_logs_s3_endpoint | default(omit) }}" endpoint: "{{ upload_logs_s3_endpoint | default(omit) }}"
partition: "{{ zuul_log_partition }}" partition: "{{ zuul_log_partition }}"

1
roles/upload-logs-swift/tasks/main.yaml
View File

@ -19,6 +19,7 @@
- name: Upload logs to swift - name: Upload logs to swift
delegate_to: localhost delegate_to: localhost
no_log: true
zuul_swift_upload: zuul_swift_upload:
cloud: "{{ zuul_log_cloud_config }}" cloud: "{{ zuul_log_cloud_config }}"
partition: "{{ zuul_log_partition }}" partition: "{{ zuul_log_partition }}"