From 69a238df46ca81e8890ebb2ace7addcbb4852911 Mon Sep 17 00:00:00 2001
From: Sorin Sbarnea <ssbarnea@redhat.com>
Date: Fri, 28 Aug 2020 12:50:21 +0100
Subject: [PATCH] Disable broken fetch-sphinx-tarball test job

Recent security fixes made to zuul made impossible to run this
test. Disabling this test until we can find a way to test it as
this is not an easy change.

This is needed because there were at least two other changes that
failed to pass because triggered this broken job. This was broken
for more than a month.

Main challenge here is that Ansible does not have any `mv` module, so
we still need to use shell. Replacing mv with copy could risk producing
out of disk space failures sooner or later.

Change-Id: If09e0430033fd2f1d6fc5e35e5ec0b10dc7c2dfe
Needed-By: https://review.opendev.org/#/c/748480/
Needed-By: https://review.opendev.org/#/c/748682/
---
 zuul-tests.d/python-jobs.yaml | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/zuul-tests.d/python-jobs.yaml b/zuul-tests.d/python-jobs.yaml
index dd74f8d0f..83a55f3bb 100644
--- a/zuul-tests.d/python-jobs.yaml
+++ b/zuul-tests.d/python-jobs.yaml
@@ -425,16 +425,19 @@
     vars:
       zuul_use_fetch_output: false
 
-- job:
-    name: zuul-jobs-test-fetch-sphinx-tarball-with-zuul-output
-    description: Test the fetch-sphinx-tarball
-    files:
-      - roles/ensure-output-dirs/.*
-      - roles/fetch-sphinx-tarball/.*
-      - roles/fetch-output/.*
-    run: test-playbooks/python/fetch-sphinx-tarball.yaml
-    vars:
-      zuul_use_fetch_output: true
+# Disabled because "Move artifacts and docs to logs dir" task would
+# fail with "Executing local code is prohibited" during testing
+# - job:
+#     name: zuul-jobs-test-fetch-sphinx-tarball-with-zuul-output
+#     description: Test the fetch-sphinx-tarball
+#     files:
+#       - roles/ensure-output-dirs/.*
+#       - roles/fetch-sphinx-tarball/.*
+#       - roles/fetch-output/.*
+#     run: test-playbooks/python/fetch-sphinx-tarball.yaml
+#     voting: false
+#     vars:
+#       zuul_use_fetch_output: true
 
 - job:
     name: zuul-jobs-test-fetch-sphinx-tarball-synchronize
@@ -486,7 +489,6 @@
         - zuul-jobs-test-fetch-subunit-output-synchronize
         - zuul-jobs-test-fetch-sphinx-output
         - zuul-jobs-test-fetch-sphinx-output-synchronize
-        - zuul-jobs-test-fetch-sphinx-tarball-with-zuul-output
         - zuul-jobs-test-fetch-sphinx-tarball-synchronize
     gate:
       jobs:
@@ -525,5 +527,4 @@
         - zuul-jobs-test-fetch-subunit-output-synchronize
         - zuul-jobs-test-fetch-sphinx-output
         - zuul-jobs-test-fetch-sphinx-output-synchronize
-        - zuul-jobs-test-fetch-sphinx-tarball-with-zuul-output
         - zuul-jobs-test-fetch-sphinx-tarball-synchronize