Rename install-go to ensure-go for consistency

The old role will be kept and include ensure-go for backwards-compatability.

Change-Id: I4e6345563817057a6c47c124b9ec8b0c62b057d6

doc/source/go-roles.rst

@@ -1,6 +1,7 @@
 Go Roles
 ========
 
+.. zuul:autorole:: ensure-go
 .. zuul:autorole:: ensure-golangci-lint
 .. zuul:autorole:: install-go
 .. zuul:autorole:: go

playbooks/go/pre.yaml

@@ -1,3 +1,3 @@
 - hosts: all
   roles:
-    - install-go
+    - ensure-go

roles/ensure-go/README.rst

@@ -0,0 +1,17 @@
+Install go
+
+**Role Variables**
+
+.. zuul:rolevar:: go_install_dir
+   :default: /usr/local/
+
+   Directory to install go in.
+
+.. zuul:rolevar:: go_version
+   :default: 1.13
+
+.. zuul:rolevar:: go_os
+   :default: {{ ansible_system | lower }}
+
+.. zuul:rolevar:: go_arch
+   :default: amd64 / 386

roles/ensure-go/tasks/main.yaml

@@ -0,0 +1,14 @@
+- name: Check installed go version
+  command: go version
+  register: go_installed_version
+  environment:
+    PATH: "{{ ansible_env.PATH }}:{{ go_install_dir }}/go/bin"
+  ignore_errors: yes
+
+- name: Skip if correct version of go is installed
+  include_tasks: install-go.yaml
+  when:
+    - go_installed_version.rc != 0 or
+      go_version != (go_installed_version.stdout|regex_replace(go_version_pattern, '\\g<version>')) or
+      go_os != (go_installed_version.stdout|regex_replace(go_version_pattern, '\\g<os>')) or
+      go_arch != (go_installed_version.stdout|regex_replace(go_version_pattern, '\\g<arch>'))

roles/install-go/README.rst

@@ -1,17 +1 @@
-Install go
+.. warning:: Deprecated, use ensure-go instead.
-
-**Role Variables**
-
-.. zuul:rolevar:: go_install_dir
-   :default: /usr/local/
-
-   Directory to install go in.
-
-.. zuul:rolevar:: go_version
-   :default: 1.13
-
-.. zuul:rolevar:: go_os
-   :default: {{ ansible_system | lower }}
-
-.. zuul:rolevar:: go_arch
-   :default: amd64 / 386

roles/install-go/tasks/main.yaml

@@ -1,14 +1,3 @@
-- name: Check installed go version
+- name: Include ensure-go
-  command: go version
+  include_role:
-  register: go_installed_version
+    name: ensure-go
-  environment:
-    PATH: "{{ ansible_env.PATH }}:{{ go_install_dir }}/go/bin"
-  ignore_errors: yes
-
-- name: Skip if correct version of go is installed
-  include_tasks: install-go.yaml
-  when:
-    - go_installed_version.rc != 0 or
-      go_version != (go_installed_version.stdout|regex_replace(go_version_pattern, '\\g<version>')) or
-      go_os != (go_installed_version.stdout|regex_replace(go_version_pattern, '\\g<os>')) or
-      go_arch != (go_installed_version.stdout|regex_replace(go_version_pattern, '\\g<arch>'))