zuul
/
zuul-jobs
Code Issues Proposed changes

ensure-twine: remove readme_renderer 

This dependency was added with
Iaf4da5aedaa3814b2ecebed4391da2324d3e388d to prevent a warning when
using "twine check" with text/markdown descriptions.

Per [1], this check doesn't really do anything and will never fail.

We are now having issues using this role with with Python 3.8 on the
executor as the md dependency pulls in cmarkgfm which has binary
dependencies but does not publish any wheels; meaning the executor
fails to install as it does not have a toolchain setup.  Unfortunately
upstream is not particularly active, so building good manylinux wheels
is not something we're going to be able to deal with in a timely
fashion.

Given that this is not a failure, and isn't really doing anything and
blocks Python 3.8, it seems our best course is to remove this
dependency.

[1] https://github.com/pypa/twine/pull/421

Change-Id: Iac5c9f63d41375889e4fdad67b9a45a24a644341
This commit is contained in:
Ian Wienand 2020-10-02 09:08:58 +10:00
parent effff59852
commit 6f76d3f68a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/ensure-twine/tasks/main.yaml
View File

@ -14,7 +14,7 @@
- name: Ensure twine is installed
block:
- name: Ensure twine is installed
command: "{{ twine_python }} -m pip install twine!=1.12.0 readme_renderer[md]!=23.0 requests-toolbelt!=0.9.0 --user"
command: "{{ twine_python }} -m pip install twine!=1.12.0 requests-toolbelt!=0.9.0 --user"
- name: Set pypi_twine_executable
set_fact: