ansible-lint: fix a bunch of command-instead-of-shell errors

These all trigger command-instead-of-shell for ansible-lint 6.12.0.
It seems a few were ignored with warnings with
I4e415cbd34f0f4cb15857051bf95458e0316de86.

I don't see why these can't be command: for consistency

Change-Id: Ib0f590b461d2a5a7d9bb8bdddcbbfb2230cc3d1c

test-playbooks/ensure-nox.yaml

@@ -2,15 +2,11 @@
   name: Remove any pre-installed nox
   tasks:
     - name: Remove nox package with pip
-      shell: pip uninstall -y nox
+      command: pip uninstall -y nox
-      args:
-        warn: false
       become: true
       failed_when: false
     - name: Remove nox package with pip3
-      shell: pip3 uninstall -y nox
+      command: pip3 uninstall -y nox
-      args:
-        warn: false
       become: true
       failed_when: false
     - name: Verify nox is not installed

test-playbooks/ensure-tox.yaml

@@ -2,15 +2,11 @@
   name: Remove any pre-installed tox
   tasks:
     - name: Remove tox package with pip
-      shell: pip uninstall -y tox
+      command: pip uninstall -y tox
-      args:
-        warn: false
       become: true
       failed_when: false
     - name: Remove tox package with pip3
-      shell: pip3 uninstall -y tox
+      command: pip3 uninstall -y tox
-      args:
-        warn: false
       become: true
       failed_when: false
     - name: Verify tox is not installed

test-playbooks/registry/buildset-registry-k8s-microk8s.yaml

@@ -22,15 +22,13 @@
         seconds: 60
 
     - name: Describe pod
-      shell: kubectl describe pods quaytest
+      command: kubectl describe pods quaytest
 
     - name: Wait for the pod to be ready
       command: kubectl wait --for=condition=Ready pod/quaytest --timeout=60s
 
     - name: Check the output of the pod
       shell: "kubectl logs pod/quaytest | grep 'Zuul container test'"
-      args:
-        warn: false
 
     - name: Run a remote test pod
       command: kubectl run --image=docker.io/debian:testing upstream-dockertest --command -- /bin/bash -c 'echo Upstream; sleep infinity'
@@ -40,12 +38,10 @@
         seconds: 60
 
     - name: Describe pod
-      shell: kubectl describe pods upstream-dockertest
+      command: kubectl describe pods upstream-dockertest
 
     - name: Wait for the pod to be ready
       command: kubectl wait --for=condition=Ready pod/upstream-dockertest --timeout=60s
 
     - name: Check the output of the pod
       shell: "kubectl logs pod/upstream-dockertest | grep 'Upstream'"
-      args:
-        warn: false

test-playbooks/tox/reinstall-tox.yaml

@@ -2,15 +2,11 @@
   name: Remove any pre-installed tox
   tasks:
     - name: Remove tox package with pip
-      shell: pip uninstall -y tox
+      command: pip uninstall -y tox
-      args:
-        warn: false
       become: true
       failed_when: false
     - name: Remove tox package with pip3
-      shell: pip3 uninstall -y tox
+      command: pip3 uninstall -y tox
-      args:
-        warn: false
       become: true
       failed_when: false
     - name: Verify tox is not installed

test-playbooks/upload-git-mirror.yaml

@@ -30,9 +30,7 @@
         key: "{{ public_key_contents.stdout }}"
 
     - name: Get localhost ssh host public key
-      shell: ssh-keyscan -t rsa localhost
+      command: ssh-keyscan -t rsa localhost
-      args:
-        warn: false
       register: host_key
   tasks:
     - name: Get git commit hash for current patch of zuul-jobs