From 7e04128a8bb3bae4561d0c65bf96f7a5c7ff6ff2 Mon Sep 17 00:00:00 2001 From: Andreas Jaeger Date: Sat, 16 May 2020 17:27:04 +0200 Subject: [PATCH] Capitalize task names We capitalize the first word in task names in general - and when you follow a log and suddenly see a single lower-case one flying along... Fix those names that I could find and that are not variables etc. Change-Id: I9ccde577413270d49fd790c41767b859366dc2f6 --- roles/bindep/handlers/main.yaml | 2 +- roles/bindep/tasks/install.yaml | 6 +++--- roles/configure-mirrors/tasks/main.yaml | 2 +- roles/configure-mirrors/tasks/mirror/Suse.yaml | 4 ++-- roles/markdownlint/tasks/main.yaml | 2 +- roles/remove-sshkey/tasks/main.yaml | 2 +- roles/set-zuul-log-path-fact/tasks/main.yaml | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/roles/bindep/handlers/main.yaml b/roles/bindep/handlers/main.yaml index d7bcdedbf..4d276f147 100644 --- a/roles/bindep/handlers/main.yaml +++ b/roles/bindep/handlers/main.yaml @@ -1,4 +1,4 @@ -- name: remove bindep temp dir +- name: Remove bindep temp dir file: path: "{{ bindep_temp_dir }}" state: absent diff --git a/roles/bindep/tasks/install.yaml b/roles/bindep/tasks/install.yaml index d720ddf9a..75027d957 100644 --- a/roles/bindep/tasks/install.yaml +++ b/roles/bindep/tasks/install.yaml @@ -1,16 +1,16 @@ -- name: create temp dir for bindep +- name: Create temp dir for bindep tempfile: state: directory prefix: bindep register: bindep_temp_dir notify: - - remove bindep temp dir + - Remove bindep temp dir - name: Ensure we have pip dependencies include_role: name: ensure-pip -- name: install bindep into temporary venv +- name: Install bindep into temporary venv pip: name: bindep virtualenv_command: '{{ ensure_pip_virtualenv_command }}' diff --git a/roles/configure-mirrors/tasks/main.yaml b/roles/configure-mirrors/tasks/main.yaml index c98c53dc7..ceec984b4 100644 --- a/roles/configure-mirrors/tasks/main.yaml +++ b/roles/configure-mirrors/tasks/main.yaml @@ -1,4 +1,4 @@ -- name: gather needed facts +- name: Gather needed facts when: ansible_pkg_mgr is not defined setup: gather_subset: pkg_mgr diff --git a/roles/configure-mirrors/tasks/mirror/Suse.yaml b/roles/configure-mirrors/tasks/mirror/Suse.yaml index df6e400bf..675b5b66e 100644 --- a/roles/configure-mirrors/tasks/mirror/Suse.yaml +++ b/roles/configure-mirrors/tasks/mirror/Suse.yaml @@ -1,9 +1,9 @@ -- name: set zypper base package repository (openSUSE Leap) +- name: Set zypper base package repository (openSUSE Leap) set_fact: opensuse_repo_baseurl: "{{ package_mirror }}/distribution/leap/$releasever/repo/oss/" when: ansible_distribution is not search("Tumbleweed") -- name: set zypper base package repository (openSUSE Tumbleweed) +- name: Set zypper base package repository (openSUSE Tumbleweed) set_fact: opensuse_repo_baseurl: "{{ package_mirror }}/tumbleweed/repo/oss/" when: ansible_distribution is search("Tumbleweed") diff --git a/roles/markdownlint/tasks/main.yaml b/roles/markdownlint/tasks/main.yaml index 612ec0154..76b50221b 100644 --- a/roles/markdownlint/tasks/main.yaml +++ b/roles/markdownlint/tasks/main.yaml @@ -1,4 +1,4 @@ -- name: find all .md files +- name: Find all .md files find: paths: "{{ zuul_work_dir }}" pattern: "*.md" diff --git a/roles/remove-sshkey/tasks/main.yaml b/roles/remove-sshkey/tasks/main.yaml index 4c3f08124..50d140a64 100644 --- a/roles/remove-sshkey/tasks/main.yaml +++ b/roles/remove-sshkey/tasks/main.yaml @@ -1,7 +1,7 @@ - name: Remove ssh key command: "shred ~/.ssh/id_rsa" -- name: remove host key information from known hosts +- name: Remove host key information from known hosts known_hosts: name: "{{ ssh_key.fqdn }}" key: "{{ ssh_key.ssh_known_hosts }}" diff --git a/roles/set-zuul-log-path-fact/tasks/main.yaml b/roles/set-zuul-log-path-fact/tasks/main.yaml index f9dff1b5a..782bf4d22 100644 --- a/roles/set-zuul-log-path-fact/tasks/main.yaml +++ b/roles/set-zuul-log-path-fact/tasks/main.yaml @@ -16,7 +16,7 @@ set_fact: zuul_log_path: "{{ zuul.pipeline }}/{{ zuul.project.canonical_name }}/{{ zuul.branch }}/{{ zuul.job }}/{{ zuul.build[:7] }}" -- name: object store friendly log path specifications +- name: Object store friendly log path specifications when: zuul_log_path_shard_build block: - name: Set log path for a change