Update patch set 1
Patch Set 1: Code-Review+1 (2 comments) Patch-set: 1 Reviewer: Gerrit User 1 <1@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1 Attention: {"person_ident":"Gerrit User 4146 \u003c4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Someone else replied on the change"}
This commit is contained in:
parent
19f0076eaa
commit
8745612bcd
|
@ -0,0 +1,38 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f7cb981a_eeb9420e",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 22,
|
||||
"author": {
|
||||
"id": 1
|
||||
},
|
||||
"writtenOn": "2022-09-22T17:32:57Z",
|
||||
"side": 1,
|
||||
"message": "We might not want to make an ansible module that does shell tasks because it would be duplicative of the command module which is complex and has lots of log streaming stuff.",
|
||||
"revId": "38c75921795ad4dd79772ce1bd06a0b5942579a2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f0c9f715_f87a822c",
|
||||
"filename": "roles/prepare-workspace-git/tasks/main.yaml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 16,
|
||||
"author": {
|
||||
"id": 1
|
||||
},
|
||||
"writtenOn": "2022-09-22T17:32:57Z",
|
||||
"side": 1,
|
||||
"message": "Should we set -x this so that if something fails, we get to see the command? Otherwise, if, say, git config failed for some reason would we be left without a debug thread to pull on?",
|
||||
"revId": "38c75921795ad4dd79772ce1bd06a0b5942579a2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue