zuul/zuul-jobs
Code Issues Proposed changes

Ignore some recent ansible-list warnings

Browse Source 
We don't need to name every play; in the Zuul context, they are
usually pretty self-evident.  It might be nice, but it doesn't
seem necessary to require it.

We really don't need to care about using upper or lower case.

The key-order seems very arbitrary and counterproductive to make
all our developers memorize someone else's arbitrary preference
for ordering.

Change-Id: I49455b6946d5d9b6bffd58420fea586ecc6c5f80
This commit is contained in:
James E. Blair 2024-09-18 09:04:32 -07:00
parent 819e0194a0
commit 8a7dd50b6b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.ansible-lint
View File

@ -9,6 +9,9 @@ skip_list:
- fqcn # similar to above - fqcn # similar to above
- risky-file-permissions # It would probably also good to enforce this if someone wants to look at them - risky-file-permissions # It would probably also good to enforce this if someone wants to look at them
- schema # This is a stricter form of schema per https://github.com/ansible/schemas. might also be good if someone has motivation? - schema # This is a stricter form of schema per https://github.com/ansible/schemas. might also be good if someone has motivation?
- key-order # This suggests an arbitrary ordering of keys which means our developers would need to memorize someone's personal preference
- name[play] # We have no objection to naming plays, but because of all of our short job playbooks, there are a *lot* of them that are pretty self-evident in the Zuul context, so it doesn't seem necessary.
- name[casing] # We should use proper capitalization, but this is too nit-picky to waste time on
# NOTE(ianw) After following the jinja formatting extensions in # NOTE(ianw) After following the jinja formatting extensions in
# ansible-lint for a few releases, this does not seem to be # ansible-lint for a few releases, this does not seem to be