Remove shebang from all python ansible modules

This commit in Ansible:
9142be2f6c

now allows Python modules to specify their interpreter with the shebang.
We expect our roles to use the discovered python interpreter on remote
nodes, and on the executor, we need them to use the virtualenv.  Removing
the specific shebang accomplishes this under Ansible 6, and has no effect
under older versions of Ansible.

Without this, for example, the log upload roles would not have access to
their cloud libraries.

Also update our ansible/cli check in our module files.  Many of our modules
can be run from the command line for ease of testing, but the check that we
perform to determine if the module is being invoked from the command line
or Ansible fails on Ansible 5.  Update it to a check that should work in
all 4 versions of Ansible that Zuul uses.

Change-Id: I4e6e85156459cca032e6c3e1d8a9284be919ccca

roles/generate-zuul-manifest/library/generate_manifest.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2019 Red Hat, Inc
 #
 # Licensed under the Apache License, Version 2.0 (the "License"); you may
@@ -131,7 +129,10 @@ def cli_main():
 
 
 if __name__ == '__main__':
-    if sys.stdin.isatty():
-        cli_main()
-    else:
+    # The zip/ansible/modules check is required for Ansible 5 because
+    # stdin may be a tty, but does not work in ansible 2.8.  The tty
+    # check works on versions 2.8, 2.9, and 6.
+    if ('.zip/ansible/modules' in sys.argv[0] or not sys.stdin.isatty()):
         ansible_main()
+    else:
+        cli_main()

roles/golangci-lint/library/golangci_lint_parse_output.py

@@ -1,5 +1,3 @@
-#!/usr/bin/python
-
 # Copyright 2020 VEXXHOST, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License"); you may

roles/htmlify-logs/library/htmlify.py

@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 # Copyright 2018 Red Hat, Inc
 #
 # Licensed under the Apache License, Version 2.0 (the "License"); you may
@@ -137,8 +136,10 @@ def cli_main():
 
 
 if __name__ == '__main__':
-
-    if sys.stdin.isatty():
-        cli_main()
-    else:
+    # The zip/ansible/modules check is required for Ansible 5 because
+    # stdin may be a tty, but does not work in ansible 2.8.  The tty
+    # check works on versions 2.8, 2.9, and 6.
+    if ('.zip/ansible/modules' in sys.argv[0] or not sys.stdin.isatty()):
         ansible_main()
+    else:
+        cli_main()

roles/multi-node-known-hosts/library/generate_all_known_hosts.py

@@ -1,5 +1,3 @@
-#!/usr/bin/python
-
 # Copyright (c) 2017 Red Hat
 #
 # This module is free software: you can redistribute it and/or modify

roles/remove-zuul-sshkey/library/sshagent_remove_keys.py

@@ -120,7 +120,10 @@ def cli_main():
 
 
 if __name__ == '__main__':
-    if sys.stdin.isatty():
-        cli_main()
-    else:
+    # The zip/ansible/modules check is required for Ansible 5 because
+    # stdin may be a tty, but does not work in ansible 2.8.  The tty
+    # check works on versions 2.8, 2.9, and 6.
+    if ('.zip/ansible/modules' in sys.argv[0] or not sys.stdin.isatty()):
         ansible_main()
+    else:
+        cli_main()

roles/sphinx/library/sphinx_check_warning_is_error.py

@@ -1,5 +1,3 @@
-#!/usr/bin/python
-
 # Copyright (c) 2017 Red Hat
 #
 # This module is free software: you can redistribute it and/or modify

roles/stage-output/library/stage_output_renames.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-#
 # Licensed under the Apache License, Version 2.0 (the "License"); you may
 # not use this file except in compliance with the License. You may obtain
 # a copy of the License at

roles/stage-output/library/test_stage_output_renames.py

@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 # Licensed under the Apache License, Version 2.0 (the "License"); you may
 # not use this file except in compliance with the License. You may obtain
 # a copy of the License at

roles/test-upload-logs-swift/library/delete_container.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2019 Red Hat, Inc
 #
 # Licensed under the Apache License, Version 2.0 (the "License"); you may

roles/test-upload-logs-swift/library/zuul_swift_upload.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2014 Rackspace Australia
 # Copyright 2018 Red Hat, Inc
 #
@@ -945,7 +943,10 @@ if __name__ == '__main__':
     requestsexceptions.squelch_warnings(
         requestsexceptions.InsecureRequestWarning)
 
-    if sys.stdin.isatty():
-        cli_main()
-    else:
+    # The zip/ansible/modules check is required for Ansible 5 because
+    # stdin may be a tty, but does not work in ansible 2.8.  The tty
+    # check works on versions 2.8, 2.9, and 6.
+    if ('.zip/ansible/modules' in sys.argv[0] or not sys.stdin.isatty()):
         ansible_main()
+    else:
+        cli_main()

roles/tox/library/tox_install_sibling_packages.py

@@ -1,5 +1,3 @@
-#!/usr/bin/python
-
 # Copyright (c) 2017 Red Hat
 #
 # This module is free software: you can redistribute it and/or modify

roles/tox/library/tox_parse_output.py

@@ -1,5 +1,3 @@
-#!/usr/bin/python
-
 # Copyright (c) 2018 Red Hat
 #
 # This module is free software: you can redistribute it and/or modify

roles/upload-afs-roots/library/zuul_afs.py

@@ -1,5 +1,3 @@
-#!/usr/bin/python
-
 # Copyright (c) 2016 Red Hat
 #
 # This module is free software: you can redistribute it and/or modify

roles/upload-forge/library/forge_upload.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # Copyright (c) 2019 Binero
 # Author: Tobias Urdin <tobias.urdin@binero.se>
 #

roles/upload-forge/library/test_forge_upload.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python
-
 # Copyright (c) 2019 Binero
 # Author: Tobias Urdin <tobias.urdin@binero.se>
 #

roles/upload-logs-base/library/delete_swift_container.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2019 Red Hat, Inc
 #
 # Licensed under the Apache License, Version 2.0 (the "License"); you may

roles/upload-logs-base/library/zuul_azure_upload.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2014 Rackspace Australia
 # Copyright 2018-2019 Red Hat, Inc
 # Copyright 2021 Acme Gating, LLC
@@ -311,7 +309,10 @@ def cli_main():
 
 
 if __name__ == '__main__':
-    if sys.stdin.isatty():
-        cli_main()
-    else:
+    # The zip/ansible/modules check is required for Ansible 5 because
+    # stdin may be a tty, but does not work in ansible 2.8.  The tty
+    # check works on versions 2.8, 2.9, and 6.
+    if ('.zip/ansible/modules' in sys.argv[0] or not sys.stdin.isatty()):
         ansible_main()
+    else:
+        cli_main()

roles/upload-logs-base/library/zuul_google_storage_upload.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2014 Rackspace Australia
 # Copyright 2018-2019 Red Hat, Inc
 #
@@ -332,7 +330,10 @@ def cli_main():
 
 
 if __name__ == '__main__':
-    if sys.stdin.isatty():
-        cli_main()
-    else:
+    # The zip/ansible/modules check is required for Ansible 5 because
+    # stdin may be a tty, but does not work in ansible 2.8.  The tty
+    # check works on versions 2.8, 2.9, and 6.
+    if ('.zip/ansible/modules' in sys.argv[0] or not sys.stdin.isatty()):
         ansible_main()
+    else:
+        cli_main()

roles/upload-logs-base/library/zuul_ibm_upload.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2014 Rackspace Australia
 # Copyright 2018-2019 Red Hat, Inc
 # Copyright 2021-2022 Acme Gating, LLC
@@ -362,7 +360,10 @@ def cli_main():
 
 
 if __name__ == '__main__':
-    if sys.stdin.isatty():
-        cli_main()
-    else:
+    # The zip/ansible/modules check is required for Ansible 5 because
+    # stdin may be a tty, but does not work in ansible 2.8.  The tty
+    # check works on versions 2.8, 2.9, and 6.
+    if ('.zip/ansible/modules' in sys.argv[0] or not sys.stdin.isatty()):
         ansible_main()
+    else:
+        cli_main()

roles/upload-logs-base/library/zuul_s3_upload.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2014 Rackspace Australia
 # Copyright 2018 Red Hat, Inc
 #
@@ -306,7 +304,10 @@ def cli_main():
 
 
 if __name__ == '__main__':
-    if sys.stdin.isatty():
-        cli_main()
-    else:
+    # The zip/ansible/modules check is required for Ansible 5 because
+    # stdin may be a tty, but does not work in ansible 2.8.  The tty
+    # check works on versions 2.8, 2.9, and 6.
+    if ('.zip/ansible/modules' in sys.argv[0] or not sys.stdin.isatty()):
         ansible_main()
+    else:
+        cli_main()

roles/upload-logs-base/library/zuul_swift_upload.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2014 Rackspace Australia
 # Copyright 2018 Red Hat, Inc
 #
@@ -418,7 +416,10 @@ if __name__ == '__main__':
     requestsexceptions.squelch_warnings(
         requestsexceptions.InsecureRequestWarning)
 
-    if sys.stdin.isatty():
-        cli_main()
-    else:
+    # The zip/ansible/modules check is required for Ansible 5 because
+    # stdin may be a tty, but does not work in ansible 2.8.  The tty
+    # check works on versions 2.8, 2.9, and 6.
+    if ('.zip/ansible/modules' in sys.argv[0] or not sys.stdin.isatty()):
         ansible_main()
+    else:
+        cli_main()

roles/validate-host/library/zuul_debug_info.py

@@ -1,5 +1,3 @@
-#!/usr/bin/python
-
 # Copyright (c) 2017 Red Hat
 #
 # This module is free software: you can redistribute it and/or modify

roles/write-inventory/library/write_inventory.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-#
 # Copyright 2018 Red Hat, Inc
 #
 # Licensed under the Apache License, Version 2.0 (the "License"); you may