Improve ensure-tox role

Avoid using ignore_errors for tasks that are likely to fail. Change-Id: I9eae9d96a3a8ed521b3c40356f95118a5647c7c1
2020-02-19 12:53:28 +00:00 · 2020-02-19 12:53:28 +00:00 · bab30ca2ca
commit bab30ca2ca
parent 9254fbb5ff
1 changed files with 3 additions and 3 deletions
--- a/test-playbooks/ensure-tox.yaml
+++ b/test-playbooks/ensure-tox.yaml
@ -34,11 +34,11 @@
    - name: Remove tox package with pip
      shell: pip uninstall -y tox
      become: true
-      ignore_errors: true
+      failed_when: false
    - name: Remove tox package with pip3
      shell: pip3 uninstall -y tox
      become: true
-      ignore_errors: true
+      failed_when: false
    - name: Verify tox is not installed
      command: "tox --version"
      register: result
@ -49,8 +49,8 @@
  tasks:
    - name: Remove tox package
      shell: pip uninstall tox || pip3 uninstall tox
+      failed_when: false
      become: true
-      ignore_errors: true
    - name: Verify tox is not installed
      command: "tox --version"
      register: result