From c3309e045ae9db9163b3d8aca35de64b8b175ebc Mon Sep 17 00:00:00 2001
From: Paul Belanger <pabelanger@redhat.com>
Date: Thu, 12 Nov 2020 14:01:57 -0500
Subject: [PATCH] Always log out of docker registry after upload

Make sure we always log out of the docker registry, as not to allow
other playbooks to use the session.

Change-Id: I65fb71884b08802b5537ecef7304129cdeb952c3
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
---
 roles/upload-docker-image/tasks/main.yaml | 35 +++++++++++++----------
 1 file changed, 20 insertions(+), 15 deletions(-)

diff --git a/roles/upload-docker-image/tasks/main.yaml b/roles/upload-docker-image/tasks/main.yaml
index 1e545d9c5..2e5ebf423 100644
--- a/roles/upload-docker-image/tasks/main.yaml
+++ b/roles/upload-docker-image/tasks/main.yaml
@@ -12,20 +12,25 @@
   command: "docker login -u {{ docker_credentials.username }} -p {{ docker_credentials.password }} {{ docker_registry }}"
   no_log: true
 
-- name: Determine if we need to use buildx
-  set_fact:
-    use_buildx: "{{ docker_images | selectattr('arch', 'defined') | list }}"
+- name: Publish docker images
+  block:
+    - name: Determine if we need to use buildx
+      set_fact:
+        use_buildx: "{{ docker_images | selectattr('arch', 'defined') | list }}"
 
-- name: Upload image to dockerhub normally
-  loop: "{{ docker_images }}"
-  loop_control:
-    loop_var: zj_image
-  include_tasks: push.yaml
-  when: not use_buildx
+    - name: Upload image to dockerhub normally
+      loop: "{{ docker_images }}"
+      loop_control:
+        loop_var: zj_image
+      include_tasks: push.yaml
+      when: not use_buildx
 
-- name: Upload image to dockerhub using buildx
-  loop: "{{ docker_images }}"
-  loop_control:
-    loop_var: zj_image
-  include_tasks: buildx.yaml
-  when: use_buildx
+    - name: Upload image to dockerhub using buildx
+      loop: "{{ docker_images }}"
+      loop_control:
+        loop_var: zj_image
+      include_tasks: buildx.yaml
+      when: use_buildx
+  always:
+    - name: Log out of registry
+      command: "docker logout {{ docker_registry }}"