Revert "install-nodejs: add support for RPM-based OSes"

This reverts commit 102374feb4.

This broke us, one cannot assume the presence of the 'command' utility.

Change-Id: If5f92650b8e0b771aa602c21bf77981d66de1ac8

roles/install-nodejs/README.rst

@@ -1,13 +1,4 @@
-Install NodeJS from nodesource.
+Install NodeJS from nodesource
-
-**OS supported**
-
-This role supports the following OS families:
-
-- Debian
-- Fedora
-- Red Hat
-- SUSE
 
 **Role Variables**
 

roles/install-nodejs/tasks/distros/install_Debian.yaml

@@ -1,43 +0,0 @@
-- name: Pin nodejs installs to nodesource
-  copy:
-    src: 00-nodesource.pref
-    dest: /etc/apt/preferences.d/00-nodesource.pref
-  become: yes
-
-- name: Add nodesource repository key
-  apt_key:
-    url: "https://deb.nodesource.com/gpgkey/nodesource.gpg.key"
-  become: yes
-
-- name: Add nodesource apt source repository
-  apt_repository:
-    repo: "deb-src https://deb.nodesource.com/node_{{ node_version }}.x {{ ansible_distribution_release }} main"
-    state: present
-  become: yes
-
-- name: Add nodesource apt repository
-  apt_repository:
-    repo: "deb https://deb.nodesource.com/node_{{ node_version }}.x {{ ansible_distribution_release }} main"
-    state: present
-    update_cache: yes
-  become: yes
-
-# Use template so that we can easily update this in the future to be able to
-# use a mirror location.
-- name: Pin NodeJS to nodesource apt repository
-  become: yes
-  template:
-    dest: /etc/apt/preferences.d/nodejs.pref
-    group: root
-    mode: 0644
-    owner: root
-    src: nodejs.pref.j2
-
-- name: Install NodeJS from nodesource
-  package:
-    name: nodejs
-    state: latest
-  become: yes
-  tags:
-    # Ignore ANSIBLE0010: We really want latest version
-    - skip_ansible_lint

roles/install-nodejs/tasks/distros/install_Fedora.yaml

@@ -1,32 +0,0 @@
-- name: Install Nodesource repository (Fedora < 29)
-  package:
-    name: "https://rpm.nodesource.com/pub_{{ node_version }}.x/fc/{{ ansible_distribution_major_version }}/{{ ansible_architecture }}/nodesource-release-fc{{ ansible_distribution_major_version }}-1.noarch.rpm"
-    state: present
-  when:
-    - ansible_distribution_major_version < 29
-  become: yes
-
-- name: Fail installation if node version < 11 (Fedora >= 29)
-  fail:
-    msg: Fedora 29 and later only support NodeJS >= 11.x
-  when:
-    - ansible_distribution_major_version >= 29
-    - node_version < 11
-
-- name: Install Nodesource repository (Fedora >= 29)
-  package:
-    name: "https://rpm.nodesource.com/pub_{{ node_version }}.x/fc/{{ ansible_distribution_major_version }}/{{ ansible_architecture }}/nodesource-release-fc{{ ansible_distribution_major_version }}-1.noarch.rpm"
-    state: present
-  when:
-    - ansible_distribution_major_version >= 29
-    - node_version >= 11
-  become: yes
-
-- name: Install NodeJS
-  package:
-    name: "nodejs"
-    state: latest
-  become: yes
-  tags:
-    # Ignore ANSIBLE0010: We really want latest version
-    - skip_ansible_lint

roles/install-nodejs/tasks/distros/install_RedHat.yaml

@@ -1,18 +0,0 @@
-- name: Install Nodesource repository
-  package:
-    name: "https://rpm.nodesource.com/pub_{{ node_version }}.x/el/{{ ansible_distribution_major_version }}/{{ ansible_architecture }}/nodesource-release-el{{ ansible_distribution_major_version }}-1.noarch.rpm"
-    state: present
-
-- name: Update yum cache
-  yum:
-    update_cache: yes
-  become: yes
-
-- name: Install NodeJS
-  package:
-    name: "nodejs"
-    state: latest
-  become: yes
-  tags:
-    # Ignore ANSIBLE0010: We really want latest version
-    - skip_ansible_lint

roles/install-nodejs/tasks/distros/install_Suse.yaml

@@ -1,17 +0,0 @@
-- name: Update zypper cache
-  zypper:
-    update_cache: yes
-  become: yes
-
-- name: Set node package name
-  set_fact:
-    nodejs_pkg: "nodejs{{ node_version }}"
-
-- name: Install NodeJS
-  package:
-    name: "{{ nodejs_pkg }}"
-    state: latest
-  become: yes
-  tags:
-    # Ignore ANSIBLE0010: We really want latest version
-    - skip_ansible_lint

roles/install-nodejs/tasks/distros/install_default.yaml

@@ -1,8 +0,0 @@
-# Note: there are possible workarounds:
-#
-# - https://github.com/nodejs/help/wiki/Installation#how-to-install-nodejs-via-binary-archive-on-linux
-# - https://github.com/nodejs/node/blob/master/BUILDING.md#building-nodejs-on-supported-platforms
-
-- name: Fail for unsupported OSes
-  fail:
-    msg: "Unsupported OS family {{ ansible_os_family }}"

roles/install-nodejs/tasks/main.yaml

@@ -1,26 +1,57 @@
-- name: Check for the presence of node
+- name: Update apt cache
-  command: command -v node
+  apt:
-  register: install_nodejs_node_installed
+    update_cache: yes
-  ignore_errors: true
+  become: yes
 
-- name: Check for the presence of npm
+- name: Install prereqs
-  command: command -v npm
+  package:
-  register: install_nodejs_npm_installed
+    name: apt-transport-https
-  ignore_errors: true
+    state: present
+  become: yes
 
-- name: Install nodejs according to distro
+- name: Pin nodejs installs to nodesource
-  include_tasks: "{{ lookup('first_found', params) }}"
+  copy:
-  vars:
+    src: 00-nodesource.pref
-    params:
+    dest: /etc/apt/preferences.d/00-nodesource.pref
-      files:
+  become: yes
-        - "install_{{ ansible_distribution }}.{{ ansible_distribution_major_version }}.yaml"
+
-        - "install_{{ ansible_distribution }}.yaml"
+- name: Add nodesource repository key
-        - "install_{{ ansible_os_family }}.yaml"
+  apt_key:
-        - "install_default.yaml"
+    url: "https://deb.nodesource.com/gpgkey/nodesource.gpg.key"
-      paths:
+  become: yes
-        - distros
+
-  when:
+- name: Add nodesource apt source repository
-    install_nodejs_node_installed.rc == 1 or install_nodejs_npm_installed == 1
+  apt_repository:
+    repo: "deb-src https://deb.nodesource.com/node_{{ node_version }}.x {{ ansible_distribution_release }} main"
+    state: present
+  become: yes
+
+- name: Add nodesource apt repository
+  apt_repository:
+    repo: "deb https://deb.nodesource.com/node_{{ node_version }}.x {{ ansible_distribution_release }} main"
+    state: present
+    update_cache: yes
+  become: yes
+
+# Use template so that we can easily update this in the future to be able to
+# use a mirror location.
+- name: Pin NodeJS to nodesource apt repository
+  become: yes
+  template:
+    dest: /etc/apt/preferences.d/nodejs.pref
+    group: root
+    mode: 0644
+    owner: root
+    src: nodejs.pref.j2
+
+- name: Install NodeJS from nodesource
+  package:
+    name: nodejs
+    state: latest
+  become: yes
+  tags:
+    # Ignore ANSIBLE0010: We really want latest version
+    - skip_ansible_lint
 
 - name: Output node version
   command: node --version