Fix linting issues found via project-config

There are no playbooks that use the roles in this repo in a way that
would lint them, however running linters in project-config found
numerous issues in these roles. Correct the roles.

Change-Id: I017532c8aed8fd90474052423c7ba2510cf84631
Signed-off-by: Jesse Keating <omgjlk@us.ibm.com>

roles/configure-mirrors/handlers/main.yaml

@@ -3,6 +3,9 @@
 - name: Update apt cache
   become: yes
   command: apt-get update
+  # skip linting for above comment
+  tags:
+    - skip_ansible_lint
 
 - name: Update dnf cache
   become: yes

roles/emit-job-header/tasks/main.yaml

@@ -1,4 +1,5 @@
-- include_role:
+- name: include the log path role
+  include_role:
     name: set-zuul-log-path-fact
 
 - debug:

roles/mirror-workspace-git-repos/tasks/main.yaml

@@ -1,17 +1,25 @@
 - name: Allow pushing to non-bare repo
-  command: "git config --local receive.denyCurrentBranch ignore"
-  args:
-    chdir: "{{ ansible_user_dir }}/{{ item.src_dir}}"
+  git_config:
+    scope: local
+    name: receive.denyCurrentBranch
+    value: ignore
+    repo: "{{ ansible_user_dir }}/{{ item.src_dir}}"
   with_items: "{{ zuul.projects }}"
 
-- name: Synchronize src repos to workspace directory
+- block:
+  # Do not lint these tasks, gets confused by git actions that cannot be done
+  # by git modules
+  tags:
+    - skip_ansible_lint
+
+  - name: Synchronize src repos to workspace directory
     command: "git push --mirror git+ssh://{{ ansible_user }}@{{ ansible_host }}/{{ ansible_user_dir }}/{{ item.src_dir}}"
     args:
       chdir: "{{ zuul.executor.work_root }}/{{ item.src_dir }}"
     with_items: "{{ zuul.projects }}"
     delegate_to: localhost
 
-- name: Determine local HEAD
+  - name: Determine local HEAD
     shell: "git status |head -1 |awk '{ print $NF }'"
     args:
       chdir: "{{ zuul.executor.work_root }}/{{ item.src_dir }}"
@@ -19,8 +27,8 @@
     delegate_to: localhost
     register: statuses
 
-# Do this as a multi-line shell so that we can do the loop once
-- name: Update remote repository state correctly
+  # Do this as a multi-line shell so that we can do the loop once
+  - name: Update remote repository state correctly
     shell: |
       # Reset is needed because we pushed to a non-bare repo
       git reset --hard

roles/upload-logs/tasks/main.yaml

@@ -1,4 +1,5 @@
-- include_role:
+- name: include the log path role
+  include_role:
     name: set-zuul-log-path-fact
 
 - name: Create log directories