Partial address ansible-lint E208

- replaces ignore with a warn, which displays issue without affecting
  the linting outcome (allowing gradual fixing)
- bumps linter to enable the warn_list feature
- fixes a set of issues, others will be fixed in follow-up

Change-Id: I7d6f8c156b06f68f681943e88860930968e7c9f9

linters-requirements.txt

@@ -2,4 +2,4 @@
 # conflict, like ansible version required by ansible-lint.
 flake8
 yamllint>=1.23.0
-ansible-lint>=4.3.0a1,<5
+ansible-lint>=4.3.4,<5

roles/configure-mirrors/tasks/mirror/CentOS-7.yaml

@@ -25,3 +25,4 @@
     section: main
     option: deltarpm
     value: 0
+    mode: 0644

roles/configure-mirrors/tasks/mirror/CentOS-8.yaml

@@ -29,3 +29,4 @@
     section: main
     option: deltarpm
     value: 0
+    mode: 0644

roles/configure-mirrors/tasks/mirror/Fedora.yaml

@@ -25,3 +25,4 @@
     section: main
     option: deltarpm
     value: "false"
+    mode: 0644

roles/ensure-output-dirs/tasks/main.yaml

@@ -13,6 +13,7 @@
   file:
     path: "{{ zuul_output_dir }}/{{ zj_output_dir }}"
     state: directory
+    mode: 0755
   with_items:
     - logs
     - artifacts

roles/fetch-output/tasks/main.yaml

@@ -13,6 +13,7 @@
   file:
     path: "{{ zj_output_dir }}"
     state: directory
+    mode: 0755
   with_items:
     - "{{ log_path }}"
     - "{{ zuul.executor.work_root }}/artifacts"

roles/fetch-python-sdist-output/tasks/main.yaml

@@ -16,6 +16,7 @@
   file:
     path: "{{ zuul.executor.work_root }}/artifacts"
     state: directory
+    mode: 0755
   delegate_to: localhost
 
 - name: Collect artifacts

roles/log-inventory/tasks/main.yaml

@@ -4,6 +4,7 @@
   file:
     path: "{{ zuul_info_dir }}"
     state: directory
+    mode: 0755
 
 # We don't use the ansible inventory_file variable because it is not defined
 # for nodeless job running on the executor directly:
@@ -13,3 +14,4 @@
   copy:
     src: "{{ zuul.executor.inventory_file }}"
     dest: "{{ zuul_info_dir }}"
+    mode: 0644

roles/upload-afs-synchronize/tasks/main.yaml

@@ -4,6 +4,7 @@
   file:
     path: "{{ afs_target }}"
     state: directory
+    mode: 0755
 - name: Upload contents to AFS
   synchronize:
     src: "{{ afs_source }}"

roles/validate-host/tasks/main.yaml

@@ -8,6 +8,7 @@
   file:
     path: "{{ zuul_info_dir }}"
     state: directory
+    mode: 0755
 
 - name: Collect information about the host
   setup:
@@ -22,6 +23,7 @@
   template:
     dest: "{{ zuul_info_dir }}/host-info.{{ validate_host_hostname_sanitized }}.yaml"
     src: templates/host-info.j2
+    mode: 0644
 
 - name: zuul_debug_info block
   block:
@@ -37,5 +39,6 @@
       template:
         dest: "{{ zuul_info_dir }}/zuul-info.{{ validate_host_hostname_sanitized }}.txt"
         src: templates/zuul-info.j2
+        mode: 0644
 
   when: ansible_python_version is version('2.7', '>=')