diff --git a/roles/bindep/tasks/find-bindep.yaml b/roles/bindep/tasks/find-bindep.yaml index ecdcbaf3a..29199bf49 100644 --- a/roles/bindep/tasks/find-bindep.yaml +++ b/roles/bindep/tasks/find-bindep.yaml @@ -16,4 +16,4 @@ - name: Define bindep_command fact set_fact: bindep_command: "{{ bindep_command_type.stdout }}" - when: not bindep_command_type|skipped and bindep_command_type.rc == 0 + when: not bindep_command_type is skipped and bindep_command_type.rc == 0 diff --git a/roles/bindep/tasks/find.yaml b/roles/bindep/tasks/find.yaml index 50bcbe471..282f78394 100644 --- a/roles/bindep/tasks/find.yaml +++ b/roles/bindep/tasks/find.yaml @@ -17,17 +17,17 @@ - name: Define bindep_file fact set_fact: bindep_file: "{{ bindep_other_file_stat.stat.path }}" - when: not bindep_other_file_stat|skipped and bindep_other_file_stat.stat.exists + when: not bindep_other_file_stat is skipped and bindep_other_file_stat.stat.exists - name: Look for bindep fallback file stat: path: "{{ bindep_fallback }}" register: bindep_fallback_file_stat when: bindep_fallback is defined - and not bindep_other_file_stat|skipped + and not bindep_other_file_stat is skipped and not bindep_other_file_stat.stat.exists - name: Define bindep_file fact set_fact: bindep_file: "{{ bindep_fallback_file_stat.stat.path }}" - when: not bindep_fallback_file_stat|skipped and bindep_fallback_file_stat.stat.exists + when: not bindep_fallback_file_stat is skipped and bindep_fallback_file_stat.stat.exists diff --git a/roles/bindep/tasks/packages.yaml b/roles/bindep/tasks/packages.yaml index 8963a40a7..f0982aef5 100644 --- a/roles/bindep/tasks/packages.yaml +++ b/roles/bindep/tasks/packages.yaml @@ -19,4 +19,4 @@ - name: Fail if we cannot install all packages fail: msg: "bindep failed to install from {{ bindep_file}} - {{ bindep_final_check.stdout }}" - when: bindep_final_check|failed + when: bindep_final_check is failed diff --git a/roles/ensure-babel/tasks/main.yaml b/roles/ensure-babel/tasks/main.yaml index df43502b3..aa116a591 100644 --- a/roles/ensure-babel/tasks/main.yaml +++ b/roles/ensure-babel/tasks/main.yaml @@ -18,12 +18,12 @@ msg: "Variable constraints_file is set but file does not exist." when: - constraints_file is defined - - not stat_results|skipped and not stat_results.stat.exists + - not stat_results is skipped and not stat_results.stat.exists - name: Record file location set_fact: upper_constraints: "-c {{ constraints_file }}" - when: not stat_results|skipped and stat_results.stat.exists + when: not stat_results is skipped and stat_results.stat.exists - name: Install babel pip: diff --git a/roles/find-constraints/tasks/main.yaml b/roles/find-constraints/tasks/main.yaml index 4a7e47528..14ddd359b 100644 --- a/roles/find-constraints/tasks/main.yaml +++ b/roles/find-constraints/tasks/main.yaml @@ -15,4 +15,4 @@ - name: Record file location set_fact: upper_constraints: "-c {{ constraints_file|realpath }}" - when: not stat_results|skipped and stat_results.stat.exists + when: not stat_results is skipped and stat_results.stat.exists diff --git a/roles/install-if-python/tasks/main.yaml b/roles/install-if-python/tasks/main.yaml index 4175b5c5f..9719d8aad 100644 --- a/roles/install-if-python/tasks/main.yaml +++ b/roles/install-if-python/tasks/main.yaml @@ -39,7 +39,7 @@ failed_when: - error_on_failure is defined - error_on_failure - - requirements_install|failed + - requirements_install is failed # Build an sdist. This is needed for pbr projects that may expect # the ChangeLog to have been generated. @@ -54,7 +54,7 @@ failed_when: - error_on_failure is defined - error_on_failure - - sdist_results|failed + - sdist_results is failed # Try installing current repo in case it needs to be available for # example for version number calculation. Ignore any failures here. @@ -71,4 +71,4 @@ failed_when: - error_on_failure is defined - error_on_failure - - install_package_results|failed + - install_package_results is failed