5 Commits

Author SHA1 Message Date
Monty Taylor
62c73aade3
Remove reference to unused variable
This isn't a thing anymore.

Change-Id: Ibb5152f74012919e21e40b19a1a59c23ce013d4a
2017-09-08 19:05:34 -05:00
Monty Taylor
15d8a916a0
Use zuul_site_traceroute_host properly
The site-variables value is zuul_site_traceroute_host.

Change-Id: I672aa96ca6f9398dea1f09891d10b05b9ada0685
2017-09-08 19:04:24 -05:00
Monty Taylor
f3e89a488c
Make validate-host read from site-variables
Change the default parameters to the role to be zuul site variables.
Because of variable precedence, having these not be site variables means
someone could override them in a job. Since one of the actions is to
read and log the contents of a file, we likely don't want to give people
the ability to do that with an arbitrary file.

The traceroute host isn't as important to be a site variable, but it's
still not actually something that jobs should override - it's a feature
of the deployment.

Both variables work if they are not set, so deployers should still be
able to use this role without defining site-variables. But it should be
made clear to them that if they want those features they really should
define the locations in a site-variable and not in a normal job
variable.

configure-mirror similarly allows in-job override, but maybe that's ok
for now and leaving the site-variable value as a default is fine?

Finally, add a new zuul_site_image_manifest_files list, so that we can
specify more than one file to read. Set the defaults of it to be the
files that the dib nodepool elements emit. We'll also look in to pushing
those manifest files up a level into dib so that expecting nodepool
nodes to have them is even more reasonable.

Change-Id: I632a32fdfac4bfe57eb269ac8e183fb8df34d48f
2017-09-07 11:18:36 -05:00
Monty Taylor
c00eca3f15
Switch to using setup instead of hostvars
hostvars can potentially leak secrets. setup doesn't, and records what
we're interested in, which is the information ansible knows about the
remote host.

Change-Id: Ice585cb3beddf4e3ecc1e692ecf4e7da8c5754b8
2017-07-13 17:08:41 -05:00
Monty Taylor
7f64bddb1d
Rename debug-ansible to validate-host
It's doing more than just outputting ansible information.

Change-Id: Icfbef10b1bcf36d75f961cd4319bc062a77efe2a
2017-07-09 11:26:50 -05:00