Commit Graph

3 Commits

Author SHA1 Message Date
Clark Boylan
4ed66807a0 Use unique loop vars to avoid conflicts
We have to be careful about avoiding outer loop loop_var conflicts in
ansible. Because the zuul-jobs roles are meant to be reconsumed
elsewhere we should not use 'item' loopvars and instead set them to
something a bit more unique.

We use a zj_ prefix to try and be unique to this repo and document this
convention.

Change-Id: I20b9327a914890e9eafcb2b36dc8c23fb472bc8f
2020-02-04 12:23:36 -08:00
Ian Wienand
e6ca2e7c84 validate-zone-db : add job and make more generic
There was a request in If3dc95d1348553e5b43683f6a36d324fb978fbed to
make the role more generic so it could handle different layouts of
zone.db files.  Make it so the role can take a list of tuples (domain,
path/to/zone.db) so that we can handle any layouts, and modify the
default searching to build this from the source directory.

Reviews in https://review.opendev.org/660888 suggested making this
defined as a generic job, so a validate-zone-db job is added.

Change-Id: I56cbc027f63787f90eef283eeb2fbb81486dcaf5
2019-05-24 10:00:49 +10:00
Ian Wienand
42b9c209ab Zone file validation role
This role uses named-checkzone to validate Bind zone.db files it finds
in the specified directory.  Helps to avoid committing broken DNS
configurations.

Needed-By: https://review.opendev.org/660888

Change-Id: If3dc95d1348553e5b43683f6a36d324fb978fbed
2019-05-23 20:32:41 +10:00