Since ansible copies files as a tempfile to the remote host by default
setting remote_src: true when the files are on the same host gives better
error messages since otherwise the source path is not reflecting the real path.
See: http://paste.openstack.org/show/792400/
Where the file in "dest:" field of unarchive is copied to a tempfile
instead of just unarchiving the tarball directly.
Change-Id: Id7478a5a3171fdd2d3bc7531e66a09414e711d3a
The sphinx regex is picking up python warnings. We can disambiguate
the two because sphinx doesn't emit a space before the message but
the python warnings module does. This adjusts the regex to do that
and adds a test file that includes warnings output.
If we need/want to make this more robust, we could also simply filter
the sphinx output for messages that start with " ?\w+Warning:".
We could also decide that we want to include python warnings.
Change-Id: Ib58cc1a2d4f673a0ce3d2a9cae306004559f5b52
This adds a 'site' metadata type to the role so that we can pull
it down later based on type instead of a user friendly "name"
Change-Id: I4c59feac26971162a29fb998a21c422ccb4efc1a
- makes ensure-podman work on additional platforms
- prevents regression on new platforms fedora-30 and centos-8
- enables validation of podman engine
Change-Id: I5842ad22d94522f707ef743622b8950839d96dff
Change bed3643b28f2b30b7f49895d8e34418077ddb3ee modified the
tox_prefer_python2 default to false; update the README.rst.
Change-Id: Ie8f9ecbb2da06f1e3a3602a4cc0975ea21c2f822
We get many false positives on the .tox directory, ignore it.
Even better would be to only handle files under version control but that
is more involved, so use the simple heuristic for .tox for now since
that catches 90+ per cent of the cases.
Change-Id: Ibb17958454a4d6bf156020fe4d9f588f3c666cc7
This change adds new jobs to run and combine phoronix test suite results.
Co-Authored-By: Nicolas Hicher <nhicher@redhat.com>
Change-Id: If94cdbd91c8d80393a71cd5c36690563de9edcd6
After stripping the work dir there should not be any absolute path
left that can be related to the repo. Thus filter them so they don't
produce mapping warnings in zuul.
Change-Id: Iadeac9b1faea63aa6009e2cfbc215853695abbe6
Some programs like sphinx emit absolute paths in error messages. Those
cannot be processed by zuul so filter them if they're part of
zuul.project.
Change-Id: Ie8af91017c26f39c3aa9ca098d4230f0688351ce
We shouldn't catch exceptions during parsing without having any
log. This makes debugging impossible. Since errors are now ignored we
can stop silently catching any exception and take the chance to harden
the parsing when we hit exceptions in the future.
Change-Id: Ie58acc4c7fbfcb7e44eef49883fb69f3bccef994
The regex used to filter for line comments needs to be fine tuned for
different linters. Instead having a huge complicated regex add support
for more specialized regexes. Start with a regex that matches spinx
output.
Change-Id: I516086bba315b8bb03a1103e1b33f1a819853be7
This patch adds a roles and jobs to run golangci-lint against a
a Golang project. It's a very popular tool for linting go code.
It also adds a simple framework which allows us to create dynamic
tests for file comments by defining a simple YAML file.
Change-Id: Ic8358541adaf7c3279383f0279cd3da7b446a6e0
The line comments needs to run after the tox run so we set failed_when
to true. However this task won't be shown as failed in the log
then. Instead ignore errors to let the playbook continue and keep the
erorr status.
Change-Id: I6f2a4043de982aa3de6e0cc4eb489914fd5805c2
Otherwise ansible will skip the test of the playbook
if the correct go version is already installed.
Change-Id: Iaa481e91738ececbdb7db7fbbdf56b27ad5995db
keystoneauth has some unit tests which output lines like:
stdin:5:1: K333 'from oslo import utils' must be used instead of 'from oslo import utils'.
The stdin isn't a file, but we try to report it back.
Pass in zuul_work_dir and use it to check that the "file"
is a file that exists.
Change-Id: I2c2aeb4e68f7d50f15ea6c6128fec6050d476c64
To make it clear which tox command a given comment came from
in the case where more than one job has messages, prepend the
tox_envlist parameter to the inline message.
Change-Id: I70228baa285c4e676dc1348c354d4bbf3a3825bc
Sometimes there are linters that are producing output where
people do not care about it enough to want to see it.
Change-Id: I0d58a3f6a4c51e1419b645a7ce1a81e6adee57d3
