This reverts commit 51a8ed8e95a2240547b0128701cc8acf6ba8bbcc.
This has a typo ("exector"). The fix is obvious, but the bigger
issue is that it was not caught in testing, even though the main
purpose of the change was to re-enable tests. We should understand
why it wasn't caught in testing and resolve that before fixing and
unreverting.
Change-Id: I3ed407546fecc52d4a039f7959c0521511e6a00b
This reverts commit 69a238df46ca81e8890ebb2ace7addcbb4852911.
The role is re-written with executor-safe methods.
Depends-On: https://review.opendev.org/753222
Change-Id: I0b52eff66bfdca776e0e5c426bf1fc57deb3fc49
This adds a custom ansible-lint rule at .rules/ZuulJobsNamespaceLoopVar.py
that enforces the loop var policy described at:
https://zuul-ci.org/docs/zuul-jobs/policy.html#ansible-loops-in-roles
It also updates existing roles to follow the policy.
Change-Id: I92b2ff56a1c2702542fc07b316f1809087a4c92f
In a multi-node job, these mv commands run in parallel which makes
the second invocation weird and racy (even though there is a mv -f
there) Put in run_once - we don't need to perform this more than
one time, no matter how many nodes there are in the nodeset.
Also, when there are actually files present, if ! $(ls work_dir/*)
winds up expanding as a command to be run.
Change-Id: Ia59c604d6639fab762fae5e53790da8992437587
When we're operating in the context of a change, we'd like to
upload artifacts and docs to the log server so that people can iterate
on them before publication safely. Add a role which is intended to be
run after fetch-output that moves the content on the executor so that
normal log upload concepts can be applied.
Change-Id: I1791d1283a0c1f112958db8861526145abe1357c