73 lines
2.6 KiB
Plaintext
73 lines
2.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f7cb981a_eeb9420e",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 22,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2022-09-22T17:32:57Z",
|
|
"side": 1,
|
|
"message": "We might not want to make an ansible module that does shell tasks because it would be duplicative of the command module which is complex and has lots of log streaming stuff.",
|
|
"revId": "38c75921795ad4dd79772ce1bd06a0b5942579a2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ecd4688e_c3b13678",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28619
|
|
},
|
|
"writtenOn": "2022-09-22T17:34:07Z",
|
|
"side": 1,
|
|
"message": "This makes way more sense now. There\u0027s no reason launching shell/commands 3 times and loop over bigger list, that needs to be merged first.",
|
|
"revId": "38c75921795ad4dd79772ce1bd06a0b5942579a2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f0c9f715_f87a822c",
|
|
"filename": "roles/prepare-workspace-git/tasks/main.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 16,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2022-09-22T17:32:57Z",
|
|
"side": 1,
|
|
"message": "Should we set -x this so that if something fails, we get to see the command? Otherwise, if, say, git config failed for some reason would we be left without a debug thread to pull on?",
|
|
"revId": "38c75921795ad4dd79772ce1bd06a0b5942579a2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9e1ac2bd_f964362e",
|
|
"filename": "roles/prepare-workspace-git/tasks/main.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 16,
|
|
"author": {
|
|
"id": 4146
|
|
},
|
|
"writtenOn": "2022-09-22T17:35:01Z",
|
|
"side": 1,
|
|
"message": "I thought about that and didn\u0027t because the old commands/shell scripts didn\u0027t. I think the concern is that this could end up being very verbose? I guess we\u0027re already getting the command output and adding a little bit of info about what is happening won\u0027t be too bad. I think we should go ahead and add it.",
|
|
"parentUuid": "f0c9f715_f87a822c",
|
|
"revId": "38c75921795ad4dd79772ce1bd06a0b5942579a2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |