We are supposed to update zuul/nodepool when the relevant secrets
are updated. We do that by subscribing to changes on all secrets
in the system, then check to see if they are ones that we're watching
and if so, run the appropriate operator methods.
We only updated the list of secrets to watch on startup, which means
that from a clean start where a zuul was added, we would not add
the new secrets to our list. This change updates the list after every
time that the zuul resource is created or updated.
Change-Id: Ib6191367eb2596eba560b9c570140f33866c005f
So that we can better test functions related to ssh connectivity,
add a static node to the functional test.
Change-Id: I3dfdaca0b4e5dbfb35e4a645c7bcb56e0eec88c2
This is the test setup I have used to run the functional tests
locally. In particular, the restart.sh script is useful for
very quickly rebuilding the cluster from scratch while also
using the local docker image cache to populate the cluster with
cached images for speed.
Change-Id: I994de1cdd49b487d68083f6e01ba73bfc4274d05
An indentation error caused the operator to only create the last
provider listed in the nodepool config.
Additionally, add the nodepool provider to the nodepool launcher
deployment spec.
This is needed to separate the pods for different nodepool launchers
(otherwise, the deployments may consider pods for one launcher to
belong to another).
Change-Id: I76bbae948d1a633028b3565d512fb48d68111dd7
Set a default of 6 hours, but allow users to tell us to wait a
longer or shorter time for executors to gracefully stop.
Change-Id: I12aada7a3c3aaff7b8bbe51744a8dd4d367b6e5a
We overrode the PXC resource values in order for functional tests
in minikube to work. Restore the defaults and set an override in
the functional tests.
Change-Id: Id0560d9089f03ddcb116dccec0b424b811186d65
The test is moved from run.yaml to test.yaml to benefit from the cluster_ip
variable that is set at the start of test.yaml.
Change-Id: Ia0d1cbac94b6b638b6f410d9647ee1822751a767
Allow the user to specify an image prefix and a version tag.
This updates the functional test to account for a recent change
in Zuul which returns incomplete builds on the API endpoint.
Change-Id: I49e82c790a518c1c9f5a463250b5b785eacde55a
This lets users specify params like "relative_priority" without
the operator needing to know about them.
Change-Id: I8a82725e51e8c7172063e0fe944a9ee9f13bada1
The external zookeeper config was mostly a stub and most of the system
actually assumed internal management. Flesh out the support for external
management. Do the same for the database.
This also passes through any additional keys in the zookeeper and database
sections of the spec.
Change-Id: I2014616e6366f8d93283e0a6ca38b288aa16a558
The operator currently creates an ingress object, but this was really
just to aid testing. The operator probably shouldn't really create one
since doing so may be site-specific.
Having the ingress greatly aids local and functional testing though, so
move it to the functional test playbook.
Change-Id: Ic6296120f8c107ecc29556fdab4d6cddb5216a50
To make the functional tests easier to run locally, run a git server
in k8s instead of on the local machine.
Also, update the secret creation to work with kind as well as minikube.
Change-Id: I4c00129c7105405b0f6256e769486e79c0b173fe
This switches from the ansible/dhall operator framework to kopf,
an operator framework written in pure Python. This allows us to:
* Build the operator application as a Python app.
* Build the operator image using the opendev python builder images.
* Run the operator as a Python CLI program "zuul-operator".
* Write procedural Python code to handle operator tasks (such as
creating new nodepool launchers when providers are added).
* Use Jinja for templating config files and k8s resource files
(direct pythonic manipulation of resources is an option too).
The new CR nearly matches the existing one, with some minor differences.
Some missing features and documentation are added in the commits
immediately following; they should be reviewed and merged as a unit.
Also, fx waiting for scheduler to settle in functional test since
we changed this log line in Zuul.
Change-Id: Ib37b67e3444b7cd44692d48eee77775ee9049e9f
Change-Id: I70ec31ecd8fe264118215944022b2e7b513dced9
This change fixes an issue where zuul services can't create
a lockfile.
Another issue happening with older operator-framework and newer
kubernetes version is being fixed by updating the operator-framework
following this migration documentation:
https://sdk.operatorframework.io/docs/building-operators/ansible/migration/
Change-Id: I6adfb907184112f0b7debb050975f76cd1dd4b01
It seems like the zuul-operator-promote-image job does not
upload the image. This change adds a new gate job to upload
the image and fix the promote job.
Depends-On: https://review.opendev.org/727868
Change-Id: Ic3b41e3b29182135f71dc1adf8c6ebd9c26d798d
This change updates the dhall code to the latest version.
* Support for record pun where `{ x = x }` can now be written as `{ x }`
* Indentation and function definitions are more compact
This change has been generated after installing dhall v1.33 using this
command: find . -name "*.dhall" -exec dhall --ascii format --inplace {} \;
Change-Id: I3b6560f26e28622aa51150dc8083d127d89a8a7b
This change ensures the pip tool is installed as it is no longer
provided by the OpenDev test instance.
Change-Id: Ie9ebf946fbf847f5574c3e140f43bdb1c9949137
This change simplifies ZooKeeper service configuration to
better describe the situation where the user provides
a zookeeper service.
Change-Id: Ic872b0e4a07acc2dedd79723e6189af2374da58a
This change adds an imagePrefix attribute to enable using
custom images for all the service at once using a single attribute
which default to "docker.io/zuul".
Change-Id: Ia1a5dd4aa9de410937f59a769019dcdb34167944
James E. Blair