5b3b779b54
Patch Set 3: (5 comments) Patch-set: 3 Label: Verified=0
89 lines
2.6 KiB
Plaintext
89 lines
2.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "7faddb67_e570cd74",
|
|
"filename": ".zuul.yaml",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 24,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2019-08-02T18:21:19Z",
|
|
"side": 1,
|
|
"message": "We shouldn\u0027t need a new image build job; we\u0027ll have the openshift job use the same registry and image we already set up for k8s.",
|
|
"revId": "fd8eb45b9ec4f9d0a62a0aa95d1c818d29c0e61d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7faddb67_856b1983",
|
|
"filename": ".zuul.yaml",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 53,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2019-08-02T18:21:19Z",
|
|
"side": 1,
|
|
"message": "Keep the build-image job running and have the openshift functional job depend on it.",
|
|
"revId": "fd8eb45b9ec4f9d0a62a0aa95d1c818d29c0e61d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7faddb67_a56655ba",
|
|
"filename": "playbooks/zuul-operator-functional-openshift/pre.yaml",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 40,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2019-08-02T18:21:19Z",
|
|
"side": 1,
|
|
"message": "Put these tasks first, and move deploy-openshift after clear-firewall and before use-buildset-registry, the same as the k8s job. That way the /var/kubelet/config.json file gets written.",
|
|
"revId": "fd8eb45b9ec4f9d0a62a0aa95d1c818d29c0e61d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7faddb67_450761cb",
|
|
"filename": "playbooks/zuul-operator-functional-openshift/run.yaml",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 39,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2019-08-02T18:21:19Z",
|
|
"side": 1,
|
|
"message": "Let\u0027s skip this task for now.",
|
|
"revId": "fd8eb45b9ec4f9d0a62a0aa95d1c818d29c0e61d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7faddb67_650a9dd2",
|
|
"filename": "playbooks/zuul-operator-functional-openshift/run.yaml",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 45,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2019-08-02T18:21:19Z",
|
|
"side": 1,
|
|
"message": "And this.",
|
|
"revId": "fd8eb45b9ec4f9d0a62a0aa95d1c818d29c0e61d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |