zuul
/
zuul-operator
Code Issues Proposed changes
zuul-operator/e20d1b5418b613be04d9b476190...

270 lines
9.3 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "1aca8fd6_179e963c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 1
},
"writtenOn": "2022-12-02T14:38:19Z",
"side": 1,
"message": "What\u0027s the upgrade story?",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4a5bd125_3eda4089",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 35201
},
"writtenOn": "2022-12-02T16:28:56Z",
"side": 1,
"message": "As in, what does it look like to upgrade from one Zuul version to the next with this?",
"parentUuid": "1aca8fd6_179e963c",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a210b19e_16fb318f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 1
},
"writtenOn": "2022-12-02T16:39:42Z",
"side": 1,
"message": "No, I meant what does it look like for an existing user of the operator to upgrade to this commit?",
"parentUuid": "1aca8fd6_179e963c",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0bbab638_d4cee00e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 1
},
"writtenOn": "2022-12-02T16:39:42Z",
"side": 1,
"message": "No, I meant what does it look like for an existing user of the operator to upgrade to this commit?",
"parentUuid": "1aca8fd6_179e963c",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4407c5c1_a5307fe1",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 1
},
"writtenOn": "2022-12-02T16:39:42Z",
"side": 1,
"message": "No, I meant what does it look like for an existing user of the operator to upgrade to this commit?",
"parentUuid": "1aca8fd6_179e963c",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ce3dfa2f_4a854d50",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 1
},
"writtenOn": "2022-12-02T16:39:42Z",
"side": 1,
"message": "No, I meant what does it look like for an existing user of the operator to upgrade to this commit?",
"parentUuid": "1aca8fd6_179e963c",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cd08b8ad_4d218107",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 1
},
"writtenOn": "2022-12-02T16:40:43Z",
"side": 1,
"message": "Er, sorry for the dupes.",
"parentUuid": "ce3dfa2f_4a854d50",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d7ce49cd_1ad74a5c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 35201
},
"writtenOn": "2022-12-02T17:28:47Z",
"side": 1,
"message": "As far as I know, nothing would change with any underlying instance itself *until* one of the config pieces change. The startup code doesn\u0027t appear to trigger any configuration updates in the underlying setup *as of this change*. \n\nGoing forward, users will likely want to re-name the underlying resources that are created such that they capture the extended name in lieu of the current non-distinct naming.",
"parentUuid": "cd08b8ad_4d218107",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9fc9dc59_aae3cab5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 1
},
"writtenOn": "2022-12-03T00:03:37Z",
"side": 1,
"message": "I think those kinds of changes are expected often enough that a user could be pretty quickly surprised by suddenly having an extra Zuul. So I think we need to account for that somehow.\n\nSome ideas (alternatives; in order of preference):\n\n1) Have the operator perform the migration itself.\n2) A release note with a migration script users can run, along with a major version number bump of the operator itself.\n3) A CRD API version bump (and naturally an operator major version bump as well).",
"parentUuid": "d7ce49cd_1ad74a5c",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e775f0c3_6dd09b26",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 1
},
"writtenOn": "2022-12-06T20:47:35Z",
"side": 1,
"message": "An additional question to consider:\n\nWhen the operator is used in the mode where it provides ZK and DB services, what will happen? I suspect those may also need to be made safe for multiple instances in the same namespace.",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "40d38692_a13f116c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 35201
},
"writtenOn": "2022-12-16T06:36:30Z",
"side": 1,
"message": "Finally getting the cycles to come back to this. I hadn\u0027t consider ZK and DB services as this is not the configuration that I\u0027m using. Seems like we\u0027d want to do that in this case. I had separated out the nodepool bits in a distinct change - I\u0027ll do the same with the dependent resources and inject it into the stack after the nodepool change. I *think* we have to do this with the cert manager bits as well.",
"parentUuid": "e775f0c3_6dd09b26",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bdb861c5_df738b10",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 35201
},
"writtenOn": "2022-12-16T06:36:30Z",
"side": 1,
"message": "One wrinkle here is around PVCs - zuul-scheduler STS and the stateful sets associated with the database + zookeeper will also have to be bumped. I\u0027m thinking that (3) might be the best option because it provides a natural breakover point. \n\nAdmittedly, I\u0027m not 100% certain of how to deal with ZooKeeper or MySQL here because this would implicitly require a data migration between ZK/MySQL instances and the actual internals of these things is opaque to the operator itself. Thoughts?",
"parentUuid": "9fc9dc59_aae3cab5",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ee7aeb1c_4c86d86b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 35201
},
"writtenOn": "2022-12-16T07:40:21Z",
"side": 1,
"message": "https://review.opendev.org/c/zuul/zuul-operator/+/867938",
"parentUuid": "40d38692_a13f116c",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "48972b2b_adae6226",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 35201
},
"writtenOn": "2023-01-28T01:49:59Z",
"side": 1,
"message": "recheck",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d98e0a2e_c79f5b56",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 18
},
"lineNbr": 0,
"author": {
"id": 35201
},
"writtenOn": "2023-02-25T04:28:44Z",
"side": 1,
"message": "recheck",
"revId": "e20d1b5418b613be04d9b4761906ca60b017b0f2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink