Browse Source

Clean up a few more warning settings

We had a few things turned off in drizzle because of the inherited
codebase and the pain of cleaning them up. Turn them back on.

Also, we don't actually need the additional lib settings in the
libcpprest test.
changes/91/636791/1
Monty Taylor 3 months ago
parent
commit
a608f98b4f
2 changed files with 3 additions and 5 deletions
  1. 0
    2
      m4/pandora_have_libcpprest.m4
  2. 3
    3
      m4/pandora_warnings.m4

+ 0
- 2
m4/pandora_have_libcpprest.m4 View File

@@ -29,8 +29,6 @@ AC_DEFUN([_PANDORA_SEARCH_LIBCPPREST],[
29 29
 web::http::client::http_client client("http://example.com/");
30 30
     ])
31 31
     CXXFLAGS="${save_CXXFLAGS}"
32
-    LIBCPPREST="${LIBCPPREST} ${PTHREAD_LIBS}"
33
-    LTLIBCPPREST="${LTLIBCPPREST} ${PTHREAD_LIBS}"
34 32
     AC_LANG_POP()
35 33
   ],[
36 34
     ac_cv_libcpprest="no"

+ 3
- 3
m4/pandora_warnings.m4 View File

@@ -185,8 +185,8 @@ foo();
185 185
            [ac_cv_safe_to_use_wformat_=no])
186 186
          CFLAGS="$save_CFLAGS"])
187 187
       AS_IF([test "$ac_cv_safe_to_use_wformat_" = "yes"],[
188
-        BASE_WARNINGS="${BASE_WARNINGS} -Wformat -Wno-format-nonliteral -Wno-format-security"
189
-        BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wformat=2 -Wno-format-nonliteral -Wno-format-security"
188
+        BASE_WARNINGS="${BASE_WARNINGS} -Wformat=2"
189
+        BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wformat=2"
190 190
         ],[
191 191
         BASE_WARNINGS="${BASE_WARNINGS} -Wno-format"
192 192
         BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wno-format"
@@ -238,7 +238,7 @@ uint16_t x= htons(80);
238 238
       ])
239 239
 
240 240
       CC_WARNINGS="${BASE_WARNINGS} -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wcast-align ${CC_WARNINGS_FULL}"
241
-      CXX_WARNINGS="${BASE_WARNINGS} -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy -Wno-long-long ${CXX_WARNINGS_FULL}"
241
+      CXX_WARNINGS="${BASE_WARNINGS} -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy ${CXX_WARNINGS_FULL}"
242 242
 
243 243
       AC_CACHE_CHECK([whether it is safe to use -Wmissing-declarations from C++],
244 244
         [ac_cv_safe_to_use_Wmissing_declarations_],

Loading…
Cancel
Save