Clean up a few more warning settings

We had a few things turned off in drizzle because of the inherited
codebase and the pain of cleaning them up. Turn them back on.

Also, we don't actually need the additional lib settings in the
libcpprest test.
This commit is contained in:
Monty Taylor 2019-02-09 18:39:04 +00:00
parent 52ba519ce2
commit a608f98b4f
2 changed files with 3 additions and 5 deletions

View File

@ -29,8 +29,6 @@ AC_DEFUN([_PANDORA_SEARCH_LIBCPPREST],[
web::http::client::http_client client("http://example.com/"); web::http::client::http_client client("http://example.com/");
]) ])
CXXFLAGS="${save_CXXFLAGS}" CXXFLAGS="${save_CXXFLAGS}"
LIBCPPREST="${LIBCPPREST} ${PTHREAD_LIBS}"
LTLIBCPPREST="${LTLIBCPPREST} ${PTHREAD_LIBS}"
AC_LANG_POP() AC_LANG_POP()
],[ ],[
ac_cv_libcpprest="no" ac_cv_libcpprest="no"

View File

@ -185,8 +185,8 @@ foo();
[ac_cv_safe_to_use_wformat_=no]) [ac_cv_safe_to_use_wformat_=no])
CFLAGS="$save_CFLAGS"]) CFLAGS="$save_CFLAGS"])
AS_IF([test "$ac_cv_safe_to_use_wformat_" = "yes"],[ AS_IF([test "$ac_cv_safe_to_use_wformat_" = "yes"],[
BASE_WARNINGS="${BASE_WARNINGS} -Wformat -Wno-format-nonliteral -Wno-format-security" BASE_WARNINGS="${BASE_WARNINGS} -Wformat=2"
BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wformat=2 -Wno-format-nonliteral -Wno-format-security" BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wformat=2"
],[ ],[
BASE_WARNINGS="${BASE_WARNINGS} -Wno-format" BASE_WARNINGS="${BASE_WARNINGS} -Wno-format"
BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wno-format" BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wno-format"
@ -238,7 +238,7 @@ uint16_t x= htons(80);
]) ])
CC_WARNINGS="${BASE_WARNINGS} -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wcast-align ${CC_WARNINGS_FULL}" CC_WARNINGS="${BASE_WARNINGS} -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wcast-align ${CC_WARNINGS_FULL}"
CXX_WARNINGS="${BASE_WARNINGS} -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy -Wno-long-long ${CXX_WARNINGS_FULL}" CXX_WARNINGS="${BASE_WARNINGS} -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy ${CXX_WARNINGS_FULL}"
AC_CACHE_CHECK([whether it is safe to use -Wmissing-declarations from C++], AC_CACHE_CHECK([whether it is safe to use -Wmissing-declarations from C++],
[ac_cv_safe_to_use_Wmissing_declarations_], [ac_cv_safe_to_use_Wmissing_declarations_],