James E. Blair
Several changes in an attempt to clarify exactly when updates and resets should and do happen: * Remove the repo_state argument from Merger.getRepo() It was unclear under what circumstances the low-level repo object honored repo_state (not much). Remove it entirely and rely on high-level Merger methods to deal with repo_state. * Have merger.setRepoState() operate on one project instead of a list of items Part of the reason we were passing repo_state to low-level methods was to reset the state for required projects in the executor. Essentially there were three cases: projects of change items, projects of non-change items, and projects of neither but in required-projects. The low-level repo_state usage only handled the last, the first is easy, and the second we handled by creating a list of non-change items and passing it to setRepoState on the merger. A simpler method of handling all of that is to reduce it to two cases: projects of change items (which need to be merged) and the rest (which need to be restored). If we do that, we can maintain a set of projects we've seen while merging in the first case, then iterate over all the remaining projects and call setRepoState on each in the second. * Remove the update call from Repo.reset() This lets us call Repo.reset() frequently (i.e., at the start of any operation that writes to the merger's git repo working dir) without performing a git fetch. We need to make sure we call Repo.update() where necessary. * Remove the reset call from Merger.updateRepo() This will now only call repo.update(), and even that will only happen if the repo_state says we should. So we can safely call this before any significant operations and know that it will update the repo if necessary. * Add an update() call to getRepoState() Because we removed the update() call from Repo.reset(), we need to add one here next to the existing call to reset(). * Add a reset call to getFiles() It relied on the reset in updateRepo. * Set execution_context to False on the executor's main merger The execution_context parameter determines whether we manipulate the origin remotes to point at the previous commit. This should be set for mergers that operate on the build work dir, but it should not be set for the main merger within the executor (so the main merger behaves just like a standalone merger). It previous was erroneously set for the executor's main merger and this change corrects that. * Add Merger.updateRepo() calls in the merger server merge method The merger needs to update and reset each repo before merging changes. Currently _mergeItem resets the repo the first time it encounters it. But we still need to update the repo. We don't want to update within the merger method because the executor performs batch updates in parallel before starting a merge and we don't want to re-do that work. So instead we add it to the merger server invocation, so it's only used in the merger:merge gearman function code path. Change-Id: I740e958357dc7bf0a6506474c5991da12ab6264e
|6 days ago|
|doc||1 day ago|
|etc||1 week ago|
|playbooks||3 days ago|
|releasenotes/notes||1 day ago|
|tests||1 day ago|
|tools||2 months ago|
|web||1 month ago|
|zuul||1 day ago|
|.coveragerc||3 years ago|
|.dockerignore||2 years ago|
|.gitignore||2 months ago|
|.gitreview||2 years ago|
|.mailmap||9 years ago|
|.stestr.conf||3 years ago|
|.zuul.yaml||2 months ago|
|COPYING||3 years ago|
|Dockerfile||2 months ago|
|LICENSE||9 years ago|
|MANIFEST.in||1 year ago|
|README.rst||2 years ago|
|TESTING.rst||1 year ago|
|bindep.txt||2 months ago|
|reno.yaml||9 months ago|
|requirements.txt||2 months ago|
|setup.cfg||1 month ago|
|setup.py||8 years ago|
|test-requirements.txt||1 year ago|
|tox.ini||2 months ago|
Zuul is a project gating system.
The latest documentation for Zuul v3 is published at: https://zuul-ci.org/docs/zuul/
If you are looking for the Edge routing service named Zuul that is related to Netflix, it can be found here: https://github.com/Netflix/zuul
There are two Zuul-related mailing lists:
A low-traffic announcement-only list to which every Zuul operator or power-user should subscribe.
General discussion about Zuul, including questions about how to use it, and future development.
You will also find Zuul developers in the #zuul channel on Freenode IRC.
Bugs are handled at: https://storyboard.openstack.org/#!/project/zuul/zuul
Suspected security vulnerabilities are most appreciated if first reported privately following any of the supported mechanisms described at https://zuul-ci.org/docs/zuul/user/vulnerabilities.html
Code reviews are handled by gerrit at https://review.opendev.org
After creating a Gerrit account, use git review to submit patches. Example:
# Do your commits $ git review # Enter your username if prompted
Join #zuul on Freenode to discuss development or usage.
Zuul is free software. Most of Zuul is licensed under the Apache License, version 2.0. Some parts of Zuul are licensed under the General Public License, version 3.0. Please see the license headers at the tops of individual source files.
Zuul requires Python 3. It does not support Python 2.
Since Zuul uses Ansible to drive CI jobs, Zuul can run tests anywhere Ansible can, including Python 2 environments.