From 0045126c3849442b3208940acf2d99c04829c179 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Fri, 20 Sep 2013 11:40:17 -0700 Subject: [PATCH] Fix items_behind error when moving a change When moving an item, we correctly reparented the items behind the item to the item that was previously ahead. But we did not remove the references to the items behind from the item that was being moved. This could result in that item maintaining references to items that were previously behind it. Generally, these would be the same and it would manifest as double entries in items_behind. Change-Id: Ibc1447867df4c6fc7b4fe954770a06c7c24fadc4 --- zuul/model.py | 1 + 1 file changed, 1 insertion(+) diff --git a/zuul/model.py b/zuul/model.py index 2d0f25674a..056f41d9bb 100644 --- a/zuul/model.py +++ b/zuul/model.py @@ -435,6 +435,7 @@ class ChangeQueue(object): item_behind.item_ahead = item.item_ahead # Add to new location item.item_ahead = item_ahead + item.items_behind = [] if item.item_ahead: item.item_ahead.items_behind.append(item) return True