zuul
/
zuul
Code Issues Proposed changes

Make updateChange actually update the change 

Several assignments in updateChange would actually just keep
appending data causing immensely large data structures (which
are later traversed putting Zuul into a significant busy loop).

Make sure that data are replaced instead of augmented.

Change-Id: I8c6528adbbe24d30f8d5bb8b55bb731fefd9941a
This commit is contained in:
James E. Blair 2013-08-21 18:19:51 -07:00
parent fba9b247bf
commit 085d99075b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
zuul/trigger/gerrit.py
View File

@ -334,6 +334,7 @@ class Gerrit(object):
change.branch = data['branch']
change.url = data['url']
max_ps = 0
change.files = []
for ps in data['patchSets']:
if ps['number'] == change.patchset:
change.refspec = ps['ref']
@ -352,6 +353,7 @@ class Gerrit(object):
# for dependencies.
return change
change.needs_change = None
if 'dependsOn' in data:
parts = data['dependsOn'][0]['ref'].split('/')
dep_num, dep_ps = parts[3], parts[4]
@ -359,6 +361,7 @@ class Gerrit(object):
if not dep.is_merged:
change.needs_change = dep
change.needed_by_changes = []
if 'neededBy' in data:
for needed in data['neededBy']:
parts = needed['ref'].split('/')